On Fri, 8 Jun 2007 17:15:45 +0800 "Luming Yu" <luming.yu@xxxxxxxxx> wrote: > The only problem known as to the acpi throttling changes in the mm tree > is a typo ,and the patch to fix it is available here. Please test and > get results back to me. BTW,the log shows that the acpi-cpufreq.ko has > problem. Would please also try not to load acpi-cpufreq. > > http://www.ussg.iu.edu/hypermail/linux/kernel/0706.0/2509.html Sigh. Is this some sort of contest to see how many things we can do wrong in a single patch? - Include a changelog - Include Signed-off-by: - Don't use attachments - If you _must_ use attachments, use text/plain, not application/octet-stream - Format code to remain within 80 columns. - Don't do "if(". Do "if (" Oh well. Good to hear that the oops got fixed, thanks. From: "Luming Yu" <luming.yu@xxxxxxxxx> Cc: Len Brown <lenb@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/acpi/processor_throttling.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff -puN drivers/acpi/processor_throttling.c~acpi-fix-oops-in-acpi_processor_throttling_seq_show drivers/acpi/processor_throttling.c --- a/drivers/acpi/processor_throttling.c~acpi-fix-oops-in-acpi_processor_throttling_seq_show +++ a/drivers/acpi/processor_throttling.c @@ -656,18 +656,20 @@ static int acpi_processor_throttling_seq pr->throttling.state_count - 1); seq_puts(seq, "states:\n"); - if (acpi_processor_get_throttling == acpi_processor_get_throttling_fadt) + if (pr->throttling.acpi_processor_get_throttling == + acpi_processor_get_throttling_fadt) { for (i = 0; i < pr->throttling.state_count; i++) seq_printf(seq, " %cT%d: %02d%%\n", (i == pr->throttling.state ? '*' : ' '), i, (pr->throttling.states[i].performance ? pr-> throttling.states[i].performance / 10 : 0)); - else + } else { for (i = 0; i < pr->throttling.state_count; i++) seq_printf(seq, " %cT%d: %02d%%\n", (i == pr->throttling.state ? '*' : ' '), i, (int)pr->throttling.states_tss[i]. freqpercentage); + } end: return 0; _ - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
