Re: [PATCH] ACPI: thinkpad-acpi: allow hotkey to input event map to be modified

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 26 May 2007, Dmitry Torokhov wrote:
> On Saturday 26 May 2007 13:31, Henrique de Moraes Holschuh wrote:
> > Add a sysfs interface to allow userspace to modify the mapping between
> > ThinkPad hotkeys and the keycode input events they generate.
> 
> No, please do not do that. We have a standard way to adjust keymap for
> an input device via EVIOCGKEYCODE/EVIOCSKEYCODE ioctls on corresponding
> event device; there is no need to invent another interface. Just define
> getkeycodes() and setkeycode() methods for your input device and be done
> with it.

I have fixed this to use the standard keycode, keycodesize and other such
stuff, now.  I am working with 2.6.20/2.6.21 as my base, so there is no
getkeycodes() and setkeycode(), but that is not a problem.  It is trivial
enough that I will just maintain two sets of the code for now.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux