On Thursday, 3 May 2007 11:45, Johannes Berg wrote: > On Thu, 2007-05-03 at 11:46 +0200, Rafael J. Wysocki wrote: > > > Well, BUG_ON() is extremely user-unfriendly, and it'd trigger even if the user > > actually didn't intend to suspend at all. > > Well, hibernation_set_ops is invoked whenever the user loads his ACPI > module with S4 possible, and typically having a BUG_ON here will make > the developers who wrote the code that calls hibernation_set_ops see it > right away while they might miss the message. > > I don't care much though, it just seems wasteful to have this string in > there when it'll never be seen by anyone but the developers who create > new hibernation_ops. You're making the dangerous assumption that all patches get tested before hitting users. ;-) Greetings, Rafael - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
