Jeff Garzik wrote: > Tejun Heo wrote: >> This patch cleans up ata_acpi_exec_tfs() and its friends. >> >> * Rename taskfile_array to ata_acpi_gtf and make it __packed as it's >> used as argument to ACPI method, and use pointer to ata_acpi_gtf and >> number of taskfiles to represent _GTF taskfiles instead of a pointer >> casted into unsigned long and byte count. This makes argument >> re-checking in do_drive_set_taskfiles() unnecessary. >> >> * Pointer in void * not in unsigned long. >> >> * Clean up do_drive_get_GTF() error handling and make >> do_drive_get_GTF() return number of taskfiles on success, 0 if _GTF >> doesn't exist or doesn't contain valid ata. -errno on other errors. >> >> * Remove superflous check for acpi->buffer.pointer. >> >> * Update taskfile_load_raw() such that printed messages look similar >> to the messages printed by ata_eh_report(). >> >> Signed-off-by: Tejun Heo <htejun@xxxxxxxxx> >> --- >> drivers/ata/libata-acpi.c | 219 >> ++++++++++++++++++++++----------------------- >> 1 files changed, 107 insertions(+), 112 deletions(-) > > ACK > > As an aside, I hate the "do_" prefix on functions. It is utterly > redundant. Okay, will drop. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
