Re: [PATCH 07/13] libata-acpi: add ATA_FLAG_ACPI_SATA port flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > Take the ACPI handle, go look for _GTF, _SDD etc and believe the
> > firmware. Nothing else works.
> 
> Actually, that's dangerous.  For example, you must not do _STM/_GTM on
> ahci becuase _STM/_GTM access PCI config registers which must not be
> accessed in achi modes and some BIOSen supply the same _STM/_GTM nodes
> whether the controller is in ata_piix mode or ahci mode.  Also, on ICH8,
> the association gets quite weird due to PCI device splitting.

You can end up with _SDD methods for SFF format controllers (or what we
think of as SFF format controllers) when we don't have the knowledge to
drive them in their full super-whizzo method (eg Marvell)

> The ACPI spec says the layout is dependent on controller interface and I
>  can see reasons why we need to follow that but not the other way
> around.  Do you have counter-examples?

The first problem is the words "the spec". 

Agreed that STM/GTM are not safe except when expected (and not always safe
when they are) but that ought to be ok as we then set all the modes
properly ourselves afterwards.

-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux