>-----Original Message----- >From: Li, Shaohua >Sent: Monday, April 02, 2007 6:34 PM >To: Pallipadi, Venkatesh >Cc: linux acpi; Brown, Len; Adam Belay >Subject: RE: [PATCH] acpi cpuidle driver should handle max_cstate > >On Tue, 2007-04-03 at 00:44 +0800, Pallipadi, Venkatesh wrote: >> >Ok, updated it. > >Signed-off-by: Shaohua Li <shaohua.li@xxxxxxxxx> > >Index: linux/drivers/acpi/processor_idle.c >=================================================================== >--- linux.orig/drivers/acpi/processor_idle.c 2007-04-03 >08:47:05.000000000 +0800 >+++ linux/drivers/acpi/processor_idle.c 2007-04-03 >08:50:50.000000000 +0800 >@@ -75,7 +75,30 @@ ACPI_MODULE_NAME("processor_idle"); > #define C2_OVERHEAD 1 /* 1us */ > #define C3_OVERHEAD 1 /* 1us */ > >-module_param(max_cstate, uint, 0644); >+void acpi_max_cstate_changed(void) >+{ >+ int cpu; >+ /* Driver will reset devices' max cstate limit */ >+ lock_cpu_hotplug(); >+ for_each_online_cpu(cpu) >+ cpuidle_force_redetect(&per_cpu(cpuidle_devices, cpu)); >+ unlock_cpu_hotplug(); >+} No hotplug lock in cpuidle please. Either we have to add a force_allcpu_redetect function or we can use the previous patch. Thanks, Venki - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html