On Thursday 29 March 2007 15:20:27 Sergei Shtylyov wrote:
> Hello.
>
> Maxim wrote:
>
> > ---
> > This adds support of suspend/resume on i386 for HPET
>
> The part after usually "---" gets cut off, the patch description and
> signoff should actially *precede* it.
>
> > Signed-off-by: Maxim Levitsky <maximlevitsky@xxxxxxxxx>
>
> > diff --git a/arch/i386/kernel/hpet.c b/arch/i386/kernel/hpet.c
> > index 0fd9fba..7c67780 100644
> > --- a/arch/i386/kernel/hpet.c
> > +++ b/arch/i386/kernel/hpet.c
> [...]
> > +static __init int hpet_register_sysfs(void)
> > +{
> > + int err;
> > +
> > + if (!is_hpet_capable())
> > + return 0;
> > +
> > + err = sysdev_class_register(&hpet_class);
> > +
> > + if (!err) {
> > + sysdev_register(&hpet_device);
> > + if (err)
> > + sysdev_class_unregister(&hpet_class);
>
> This doesn't make sense, err will always be 0. Perhaps you actually
> intended to check the result of sysdev_register()?
>
> > + }
> > +
> > + return err;
> > +}
> > +
> > +device_initcall(hpet_register_sysfs);
> > +
> > +#endif
>
> WBR, Sergei
>
Hi,
Big thanks for pointing this out,
I will resend that updated patch.
Best regards,
Maxim Levitsky
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
