> should they be attached to the scsi code rather than the ata host code? > Anyway, this fixes suspend/resume on nc6220, which is what I was aiming > for... > > Signed-off-by: Matthew Garrett <mjg59@xxxxxxxxxxxxx> NAK - there is code to do the _gtm/_stm parts in the -mm tree already used by pata_acpi, waiting to be merged and it's a lot cleaner. It does want hooking to the suspend/resume paths as well as to pata_acpi but that is all. This code also has bugs > + > + if (ap->cbl == ATA_CBL_SATA) > + return; Bangs head against wall. As I keep saying you *CANNOT* do any PATA v SATA decisions based upon cable type. It just doesn't work. The kernel sometimes doesn't know. The hardware sometimes turns up in weird formats with ATA bridges. You *MUST* see if the device has GTF/GTM or SATA methods in its ACPI space and decide based upon that alone what the BIOS thinks should be used. - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
