On Thu, 22 Mar 2007, Len Brown wrote: > On Tuesday 20 March 2007 05:21, Zhang Rui wrote: > > From: Zhang Rui <rui.zhang@xxxxxxxxx> > > > > Add ACPI Fan device sysfs interface. > > > > Attribute Mode Description > > state RW Fan state. > > 0: Fan is in D0 state(on). > > 3: Fan is in D3 state(off). > > I hate the current /proc/acpi/fan/*/interface, > and don't think we should carry it forward into sysfs. > > Forced to propose an alternative, I'd say: > > 0: off > 1: on-lowest speed > 2: on-next faster speed > 3: on-next faster speed > ... > n: maximum speed Shouldn't we use the hwmon interface for fans as much as possible? ibm-acpi, for example, managed to map 100% of its fan and thermal interfaces to hwmon, with no loss of functionality. I know this is not straightforward at all for generic ACPI, but it is better to do 90% than 0%... > Note that for some systems, the different fan speeds are actually > exported as multiple fan devices, each with a simple on/off. Yuck. IMHO, the right thing to do, if such systems can be identified, would be to abstract this back to just one fan with multiple speeds. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
