[PATCH] prevent ACPI quirk warning mass spamming in logs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

The following patch prevent this warning to be displayed again & again
(eg: nine times on my NForce2 motherboard) and thus improve signal to
noise ratio in logs.

The ATI quirk below probably needs a similar "fix" but I don't have
the hardware to test.

Btw arch/x86_64/kernel/early-quirks.c::nvidia_bugs() would probably
need to be synced (but I don't have an x86_64 NVidia motherboard to
boot test it). Still it shows the usefullness of the recent x86 merge
thread.

    Signed-off-by: Thierry Vignaud <tvignaud@xxxxxxxxxxxx>

The following patch prevent this warning to be displayed again & again
(eg: nine times on my NForce2 motherboard) and thus improve signal to
noise ratio in logs.

The ATI quirk below probably needs a similar "fix" but I don't have
the hardware to test.

Btw arch/x86_64/kernel/early-quirks.c::nvidia_bugs() would probably
need to be synced (but I don't have an x86_64 NVidia motherboard to
boot test it). Still it shows the usefullity of the recent x86 merge
thread.

    Signed-off-by: Thierry Vignaud <tvignaud@xxxxxxxxxxxx>

--- ./arch/i386/kernel/acpi/earlyquirk.c.tv1	2007-03-18 20:42:17.000000000 +0100
+++ ./arch/i386/kernel/acpi/earlyquirk.c	2007-03-18 20:44:06.000000000 +0100
@@ -22,11 +22,13 @@
 
 static int __init check_bridge(int vendor, int device)
 {
+	static int warned = 0;
 #ifdef CONFIG_ACPI
 	/* According to Nvidia all timer overrides are bogus unless HPET
 	   is enabled. */
 	if (!acpi_use_timer_override && vendor == PCI_VENDOR_ID_NVIDIA) {
-		if (acpi_table_parse(ACPI_SIG_HPET, nvidia_hpet_check)) {
+		if (!warned && acpi_table_parse(ACPI_SIG_HPET, nvidia_hpet_check)) {
+			warned = 1;
 			acpi_skip_timer_override = 1;
 			  printk(KERN_INFO "Nvidia board "
                        "detected. Ignoring ACPI "
the same as attachment in case an MTA garbages the inline one:
The following patch prevent this warning to be displayed again & again
(eg: nine times on my NForce2 motherboard) and thus improve signal to
noise ratio in logs.

The ATI quirk below probably needs a similar "fix" but I don't have
the hardware to test.

Btw arch/x86_64/kernel/early-quirks.c::nvidia_bugs() would probably
need to be synced (but I don't have an x86_64 NVidia motherboard to
boot test it). Still it shows the usefullity of the recent x86 merge
thread.

    Signed-off-by: Thierry Vignaud <tvignaud@xxxxxxxxxxxx>

--- ./arch/i386/kernel/acpi/earlyquirk.c.tv1	2007-03-18 20:42:17.000000000 +0100
+++ ./arch/i386/kernel/acpi/earlyquirk.c	2007-03-18 20:44:06.000000000 +0100
@@ -22,11 +22,13 @@
 
 static int __init check_bridge(int vendor, int device)
 {
+	static int warned = 0;
 #ifdef CONFIG_ACPI
 	/* According to Nvidia all timer overrides are bogus unless HPET
 	   is enabled. */
 	if (!acpi_use_timer_override && vendor == PCI_VENDOR_ID_NVIDIA) {
-		if (acpi_table_parse(ACPI_SIG_HPET, nvidia_hpet_check)) {
+		if (!warned && acpi_table_parse(ACPI_SIG_HPET, nvidia_hpet_check)) {
+			warned = 1;
 			acpi_skip_timer_override = 1;
 			  printk(KERN_INFO "Nvidia board "
                        "detected. Ignoring ACPI "

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux