On Friday 16 March 2007 22:33, Lebedev, Vladimir P wrote: > > Len, Alexey, > > This is the final SBS driver patch series. > > There are two main features: > 1) Not needed I2C using is removed. > 2) Common interface with CM battery driver is implemented: > buffering, update_time parameter, etc ... Does this build in the upstream Linus tree for you? drivers/acpi/sbs.c:188: error: field ‘update_timer’ has incomplete type drivers/acpi/sbs.c: In function ‘acpi_sbs_update_time’: drivers/acpi/sbs.c:1608: error: ‘jiffies’ undeclared (first use in this function) drivers/acpi/sbs.c:1608: error: (Each undeclared identifier is reported only once drivers/acpi/sbs.c:1608: error: for each function it appears in.) drivers/acpi/sbs.c:1608: error: ‘HZ’ undeclared (first use in this function) drivers/acpi/sbs.c:1612: warning: implicit declaration of function ‘add_timer’ drivers/acpi/sbs.c: In function ‘acpi_sbs_add’: drivers/acpi/sbs.c:1698: warning: implicit declaration of function ‘init_timer’ drivers/acpi/sbs.c: In function ‘acpi_sbs_remove’: drivers/acpi/sbs.c:1735: warning: implicit declaration of function ‘del_timer_sync’ make[1]: *** [drivers/acpi/sbs.o] Error 1 When you send the updated series, please include a Signed-off-by: line at the end of each pach comment. thanks, -Len - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
