Re: [PATCH - 2.6.19 -0/1] Backport of psmouse suspend/shutdown cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/22/07, Thomas Renninger <trenn@xxxxxxx> wrote:

When adding the .shutdown workaround I went down and realized it must be
this:
       psmouse_set_state(psmouse, PSMOUSE_CMD_MODE);
or this:
       psmouse_set_state(psmouse, PSMOUSE_IGNORE);

as I added the stuff in serio.c, I didn't realize that your psmouse
patch is enough...

So it's the first command that is needed on shutdown(PSMOUSE_CMD_MODE)?
Dmitry: Could you explain me in a short sentence what this is doing, so
that I can explain HP the problem again more detailed (without reading
specs...).


Actually there are 2 pieces that are needed for HP laptops:

1. They really get upset if mouse (integrated synaptics touchpad) is
disabled when they about to reboot. The original code was simply doing
psmouse_reset() which issues reset command to clear state of the
device so it will be "closer" to the boot state. Hovewer (in
accordance to the spec) after reset mice stay disabled, so we have to
issue:

     ps2_command(&psmouse->ps2dev, NULL, PSMOUSE_CMD_ENABLE);

to keep HP laptops happy. Why it would make any difference is a mystery to me.

2. Synaptics touchpads do not get fully reset by 0xff, we need to
explicitely enable gestures - again, HP only (there may be other boxes
with this problem of course). So we call psmouse->cleanup(psmouse) to
activate protocol-specific cleanup.

Hope this makes sense (I must admit it makes little sense to me ;) ).

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux