l> From: Eric W. Biederman [mailto:ebiederm@xxxxxxxxxxxx]
Sent: Friday, February 16, 2007 2:22 AM To: Protasevich, Natalie Cc: Len Brown; Andi Kleen; lkml - Kernel Mailing List; linux-acpi@xxxxxxxxxxxxxxx Subject: Re: [PATCH] i386: irq: Kill IRQ compression ebiederm@xxxxxxxxxxxx (Eric W. Biederman) writes: > By itself I don't think we are going to observe any real problems > with this patch. > > However if we are going to be serious about this we need to do a > few more things. > > - kill ioapic_renumber_irq. Looking closer ioapic_renumber_irq does not appear to be an irq compress thing. Rather it appears to be a work around for a weird acpi implementation where gsi 0 - 15 are not the ISA irqs. Natalie is my reading of the code there correct?
Yes, indeed.
If so keeping ioapic_renumber_irq makes sense. Although giving it a name that suggests it is working around weird implementation details would be good.
Sure. I think it was originally renumber_gsi something, but Len had to change it so it sounds more explicit as familiar "IRQ". --Natalie
Eric
- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
