On Tue, Jan 09, 2007 at 03:28:45PM -0200, Henrique de Moraes Holschuh wrote: > A new one for you, it exists since 2.6.20-rc2. > > Subject : ThinkPad removable bay support disabled unconditionally > References : http://marc.theaimsgroup.com/?l=linux-acpi&m=116750681901208&w=2 > Caused-By : Henrique de Moraes Holschuh <hmh@xxxxxxxxxx> > Handled-By : Henrique de Moraes Holschuh <hmh@xxxxxxxxxx> > Status : patch attached Thanks, noted. > From: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx> > > ACPI: ibm-acpi: fix Kconfig entries for ibm-acpi bay and dock > > Support for ACPI_BAY has not been merged in mainline yet. Usage of > "depends on FOO=n" fails if FOO is undefined, thus ibm-acpi support > for bay was being made non-available in a kernel that has no other > sort of bay support. > > Fix it to use "depends on ! FOO" instead, that does the right thing > when FOO is undefined. Fix ACPI_IBM_DOCK accordingly as well while > at it, and also improve the help text. > > Signed-off-by: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx> > --- > drivers/acpi/Kconfig | 17 ++++++++++------- > 1 files changed, 10 insertions(+), 7 deletions(-) > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig > index 1639998..34cc8d5 100644 > --- a/drivers/acpi/Kconfig > +++ b/drivers/acpi/Kconfig > @@ -215,26 +215,29 @@ config ACPI_IBM > config ACPI_IBM_DOCK > bool "Legacy Docking Station Support" > depends on ACPI_IBM > - depends on ACPI_DOCK=n > - default n > + depends on ! ACPI_DOCK > + default y >... !ACPI_DOCK is wrong if the intention was ACPI_DOCK=n (since ACPI_DOCK is a tristate). I'd say the right fix is to remove the negative dependencies on unmerged options and reintroduce them once these options themselves got merged. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
