Re: [PATCH 21/28] ACPI: update comments in motherboard.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Saturday 14 October 2006 02:06, Len Brown wrote:
> --- a/drivers/acpi/motherboard.c
> +++ b/drivers/acpi/motherboard.c
> ...
> > +/* 
> + * When CONFIG_PNP is enabled, pnp/system.c binds to PNP0C01
> + * and PNP0C02, redundant with acpi_reserve_io_ranges().
> + * But acpi_reserve_io_ranges() is necessary for !CONFIG_PNP.
> + */
>  static acpi_status acpi_reserve_io_ranges(struct acpi_resource *res, void *data)

I don't understand this comment.

IMHO, we should make CONFIG_ACPI should select CONFIG_PNP and
CONFIG_PNPACPI, move the FADT resource reservations somewhere
else in ACPI, make pnp/system.c reserve all the resources (not
just I/O ports), and remove acpi/motherboard.c.

Bjorn
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux