On Wed, Dec 20, 2006 at 01:30:02AM -0500, Len Brown wrote:
> Applied.
>
> (note the comment was incorrect this was introduced long before that commit).
It was introduced by this commit since this commit added the NULL check.
> Thanks Coverity, Adrian,
> -Len
>
> On Tuesday 19 December 2006 15:56, akpm@xxxxxxxx wrote:
> > From: Adrian Bunk <bunk@xxxxxxxxx>
> >
> > This patch fixes a non-working NULL check introduced by commit
> > b229cf92eee616c7cb5ad8cdb35a19b119f00bc8.
> >
> > Spotted by the Coverity checker.
> >
> > Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
> > Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
> > ---
> >
> > drivers/acpi/osl.c | 2 +-
> > 1 files changed, 1 insertion(+), 1 deletion(-)
> >
> > diff -puN drivers/acpi/osl.c~drivers-acpi-oslc-fix-a-null-check drivers/acpi/osl.c
> > --- a/drivers/acpi/osl.c~drivers-acpi-oslc-fix-a-null-check
> > +++ a/drivers/acpi/osl.c
> > @@ -1032,7 +1032,7 @@ acpi_status
> > acpi_os_create_cache(char *name, u16 size, u16 depth, acpi_cache_t ** cache)
> > {
> > *cache = kmem_cache_create(name, size, 0, 0, NULL, NULL);
> > - if (cache == NULL)
> > + if (*cache == NULL)
> > return AE_ERROR;
> > else
> > return AE_OK;
> > _
> >
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
