> > While this addresses the potential name conflict of the previous version, > > I think this needs some work. > > > > $ ls /sys/devices/0 > > 1 10 2 3 4 5 57 6 7 8 9 bus hid path power subsystem uevent > > > > Assigning the unique numbers in a depth-first search > > leaves irritating gaps -- (see 10 and 57 above). > That's true. > But you know, ACPI namespace is a tree in nature. Depth-first is the > fastest way to traverse the ACPI namespace. > > Instance numbers need to be per-directory. > > > instance numbers should be unique in the whole ACPI bus, as all of them > are linked to /sys/bus/acpi/devices/. In sysfs, a directory is a kernel/user API. A user-program will want to open directory entries by name, and the names should make some sense. The names in /sys/bus/acpi/devices/ and the names in /sys/devices do not have to be the same. > > Also, IMHO, the numbers by themselves look a little strange, > > maybe dev0, dev1, dev%d etc. wouldn't look so strange? > > > Yes, I can do that. :) > > Also, the ACPI spec has some pre-defined root name-spaces, and I think > > it makes sense to look up the device name against a small table of > > those reserved names and print something more interesting than > > a number. > > > > eg. > > _SB system_bus > > _PR processors > > _TZ thermal_zones > > _SI system_indicators > > _GPE events > > > Yeah. I can do that. But few devices can benefit from this. :(. > > > BTW: Maybe I can generate a patch to get the following result: > Five devices with the fixed name shown above if they are declared in the > BIOS > And add a prefix for every devices, the prefix is one of fixed names, > _SB _PR _TZ _SI _GPE. So devices are shown like _SB:dev001, _TZ:dev001, > _PR:dev033 etc. > But does this make sense? :( No. My point is that if it a _TZ then we know that it is a "thermal_zone" an we can just print "thermal_zone". There is no reason to make this cryptic by using the ACPI device names -- they have fixed definitions and in these few cases we can take advantage of that. > The best way is to define a unique and meaning rule to name all the ACPI > devices. Unfortunately we haven't reached an agreement until now, but I > think we can leave this for further discussion. see next message. - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
