On Wed, 27 Sep 2006, Andi Kleen wrote: > > It doesn't matter much because these days this stuff is all out of lined > anyways and in a single function. And the dynamic branch predictor > in all modern CPUs will usually cache the decision (unlocked) there. Ahh, good point. Once there's only one copy, the branch predictor will get it right (and the code size won't much matter) > > Are there any _real_ advantages to this broken unwinding code that has had > > more bugs that Windows XP? > > I thought for a long time we didn't need it either, but these days with all > these callbacks in some parts of the kernel (driver model, others) and you > get a oops with 60+ entries it is just too much trouble to figure it out manually. Ok, fair enough. I'll apply your fix (which in itself is obviously correct). I just wanted to bring up the possibility that we should just remove the (fragile) unwinder. But let's leave it for another day, if it keeps being problematic. Linus - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
