Re: T30 boot hang with CONFIG_PM_LEGACY=n

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 27, 2006 at 12:00:40AM -0400, Len Brown wrote:
 > My T30 doesn't boot if CONFIG_PM_LEGACY=n
 > unless "apm=off".
 > 
 > Seems that this build option causes PM_IS_ACTIVE() to be constant 0,
 > which disables APM's check to see if ACPI is running:
 > 
 > apm_init()
 > 	...
 >         if (PM_IS_ACTIVE()) {
 >                 printk(KERN_NOTICE "apm: overridden by ACPI.\n");
 >                 apm_info.disabled = 1;
 >                 return -ENODEV;
 >         }
 > 
 > Apparently when CONFIG_PM_LEGACY was created, CONFIG_APM depended
 > on it, so apm.c wasn't built.  But that dependency was later removed so it is now possible
 > to build APM with its check for ACPI  mysteriously disabled -- much to the unhappyness
 > of my T30.
 > 
 > What's the plan here?

Good question.  There's no real replacement for pm_active in the non-legacy
config afaik. Perhaps the cleanest alternative is to undeprecate that macro?
The only other option I can think of is doing something like this in apm.c ...

+#ifdef CONFIG_ACPI
-        if (PM_IS_ACTIVE()) {
                 printk(KERN_NOTICE "apm: overridden by ACPI.\n");
                 apm_info.disabled = 1;
                 return -ENODEV;
-         }
+#endif

	Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux