On Thu, 2006-08-31 at 02:48 -0400, Len Brown wrote: > On Tuesday 29 August 2006 16:04, Moore, Robert wrote: > > As far as the unknown exception, > > > > >[ 9.392729] [<c0246fb6>] acpi_ut_status_exit+0x31/0x5e > > >[ 9.393453] [<c0243352>] acpi_walk_resources+0x10e/0x11b > > >[ 9.394174] [<c025697e>] acpi_motherboard_add+0x22/0x31 > > > > I would guess that the callback routine for walk_resources is returning > > a non-zero status value which is causing an immediate abort of the walk > > with that value -- and the value is bogus. Before I put this check in acpi_motherboard_add always attached itself to any resource type. I simply changed it so if the type is not ACPI_RESOURCE_TYPE_IO or ACPI_RESOURCE_TYPE_FIXED_IO it doesn't attach and can continue to find the correct device to attach to. Perhaps the motherboard device needs to attach to more device types? It was suggest by acpi folks to return -EINVAL. Should something else be returned? Thanks, Keith > Yep, see -EINVAL below. > > -Len > > http://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc4/2.6.18-rc4-mm3/broken-out/hot-add-mem-x86_64-acpi-motherboard-fix.patch > > > > From: Keith Mannthey <kmannth@xxxxxxxxxx> > > This patch set allow SPARSEMEM and RESERVE based hot-add to work. I have > test both options and they work as expected. I am adding memory to the > 2nd node of a numa system (x86_64). > > Major changes from last set is the config change and RESERVE enablment. > > > This patch: > > > Make ACPI motherboard driver not attach to devices/handles it dosen't expect. > Fix a bug where the motherboard driver attached to hot-add memory event and > caused the add memory call to fail. > > Signed-off-by: Keith Mannthey<kmannth@xxxxxxxxxx> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > Cc: Andi Kleen <ak@xxxxxx> > Signed-off-by: Andrew Morton <akpm@xxxxxxxx> > --- > > > diff -puN drivers/acpi/motherboard.c~hot-add-mem-x86_64-acpi-motherboard-fix drivers/acpi/motherboard.c > --- a/drivers/acpi/motherboard.c~hot-add-mem-x86_64-acpi-motherboard-fix > +++ a/drivers/acpi/motherboard.c > @@ -87,6 +87,7 @@ static acpi_status acpi_reserve_io_range > } > } else { > /* Memory mapped IO? */ > + return -EINVAL; > } > > if (requested_res) > @@ -96,11 +97,16 @@ static acpi_status acpi_reserve_io_range > > static int acpi_motherboard_add(struct acpi_device *device) > { > + acpi_status status; > if (!device) > return -EINVAL; > - acpi_walk_resources(device->handle, METHOD_NAME__CRS, > + > + status = acpi_walk_resources(device->handle, METHOD_NAME__CRS, > acpi_reserve_io_ranges, NULL); > > + if (ACPI_FAILURE(status)) > + return -ENODEV; > + > return 0; > } > > _ - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
