On Tue, 15.08.06 14:42, Thomas Renninger (trenn@xxxxxxx) wrote: > > +config ACPI_MSI_S270 > > + tristate "MSI S270 Laptop Extras" > > + depends on X86 > > + depends on BACKLIGHT_CLASS_DEVICE > > + ---help--- > > + This is a Linux ACPI driver for MSI S270 laptops. It adds > > + support for Bluetooth, WLAN and LCD brightness control. > > + > > + More information about this driver is available at > > + <http://0pointer.de/lennart/tchibo.html>. > > + > > + If you have an MSI S270 laptop, say Y or M here. > > I don't know anything about MSI laptops. But S270 sounds like a very > specific model to me? There are quite a lot of different S270 laptops. And the laptops are sold under various brands and names, hence it's not that specific. Until now I found the laptop under the brands MSI, Cytron, TCM, Medion, Tchibo and the names MegaBook, S270, MD96100, MS-1013, SAM2000. And I am sure there are even more names/brands... > Shouldn't the driver just be called acpi_msi driver and try to also > support other MSI models later that might do things at least > similar? The driver uses the ACPI EC but doesn't call any ACPI DSDT method. On request of Len Brown I moved the driver out of the /drivers/acpi/ namespace and made it use sysfs instead of /proc/acpi: http://lwn.net/Articles/194916/ Hence I don't think it is a good idea to prefix the driver name with "acpi_". I would like to support other laptop models from MSI (specifically S260), however I don't have access to any of them or to the necessary hardware information. But yes, I guess I could rename the driver to "laptop_msi.c" or something. Although I don't know if the other models use a similar ACPI EC interface to the S270 model. If anyone has a S260 and wants to test this driver on it: please contact me! Lennart -- Lennart Poettering; lennart [at] poettering [dot] net ICQ# 11060553; GPG 0x1A015CC4; http://0pointer.net/lennart/ - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
