On Monday 14 August 2006 00:33, Pavel Machek wrote: > On Thu 2006-08-10 22:51:20, Rafael J. Wysocki wrote: ]--snip--[ > > > > > BTW, it's a dangerous setting, because some drivers get mad if the time after > > > > > the resume appears to be earlier than the time before the suspend. Also the > > > > > timer .suspend/.resume routines aren't prepared for that. > > > > > > > > Its config option should just go away. People comfortable using *that* > > > > should just edit some header file. Rafael, could you do patch doing > > > > something like that? > > > > > > Just remove the option from Kconfig or the whole setting? > > > > > > Shouldn't we also change the timer .resume() routines to check if the time > > > after the resume is later than (or at least the same as) the time before the > > > suspend and set the "sleep length" to 0 if not? > > > > Hm, I'm thinking it may actually be useful to have in Kconfig and if we change > > the timer resume to detect the dangerous situation and prevent it from > > happening, that should be sufficient. > > Well, it is still too easy to shoot yourself in the foot. Your time > will be wrong if you enable innocent-sounding option. We can add DANGEROUS to it. :-) Rafael - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
