On Wed, 12 Jul 2006, Linus Torvalds wrote: > > Any reason to not just revert it? The fundamental problems that it > introduces are obviously much worse than the fix. Ok, that commit b8d35192c55fb055792ff0641408eaaec7c88988 is definitely horribly horribly broken. I'm going to revert it, because the "fix" is much worse than the problem it fixes. Instead of a fan not coming on, I now have ten thousand threads killing the machine instead - and the fan _still_ doesn't come on.. The thread approach doesn't even fix the fundamental problem itself. It doesn't help to start a new thread, when the AML interpreter holds a semaphore over the sleep, causing the events to be serialized, and the thermal events to be delayed _anyway_. The only thing the threading causes is that it guarantees that the machine ends up being totally overwhelmed by the thousands of threads, all blocked on the same semaphore. I don't know what the solution should be, but in the meantime, the "fix" is definitely unacceptable. Linus - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
