This is syntatically correct, and I'll apply it. For this to actually trigger, it appears that create_dir() would have to fail, which is hard to imagine. One might question the value of /sys/firmware/acpi based on the fact that the only thing we do differently if we can't create it is print a message... -Len >-----Original Message----- >From: Randy.Dunlap [mailto:rdunlap@xxxxxxxxxxxx] >Sent: Wednesday, July 12, 2006 1:47 AM >To: lkml; linux-acpi@xxxxxxxxxxxxxxx >Cc: Brown, Len; akpm >Subject: [PATCH -mm] acpi: handle firmware_register init errors > >From: Randy Dunlap <rdunlap@xxxxxxxxxxxx> > >Check and handle init errors. > >Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx> >--- > drivers/acpi/bus.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletion(-) > >--- linux-2618-rc1mm1.orig/drivers/acpi/bus.c >+++ linux-2618-rc1mm1/drivers/acpi/bus.c >@@ -25,6 +25,7 @@ > #include <linux/module.h> > #include <linux/init.h> > #include <linux/ioport.h> >+#include <linux/kernel.h> > #include <linux/list.h> > #include <linux/sched.h> > #include <linux/pm.h> >@@ -738,7 +739,10 @@ static int __init acpi_init(void) > return -ENODEV; > } > >- firmware_register(&acpi_subsys); >+ result = firmware_register(&acpi_subsys); >+ if (result < 0) >+ printk(KERN_WARNING "%s: firmware_register error: %d\n", >+ __FUNCTION__, result); > > result = acpi_bus_init(); > > > >--- > - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
