While SBS is rare in the general population, it is common on some product lines, and thus this should have the same default as the regular battery driver. Rahter than y or n, neither should have any default -- I'll fix that now. thanks, -Len >-----Original Message----- >From: akpm@xxxxxxxx [mailto:akpm@xxxxxxxx] >Sent: Friday, July 07, 2006 2:53 AM >To: Brown, Len >Cc: linux-acpi@xxxxxxxxxxxxxxx; akpm@xxxxxxxx; >dtor@xxxxxxxxxxxxx; dtor@xxxxxxx >Subject: [patch 4/5] ACPI: disable SBS by default > >From: Dmitry Torokhov <dtor@xxxxxxxxxxxxx> > >Kconfig help even says that SBS is pretty rare and already >obsolete so it >does not make sence to keep it enabled. > >Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx> >Signed-off-by: Andrew Morton <akpm@xxxxxxxx> >--- > > drivers/acpi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff -puN drivers/acpi/Kconfig~acpi-disable-sbs-by-default >drivers/acpi/Kconfig >--- a/drivers/acpi/Kconfig~acpi-disable-sbs-by-default >+++ a/drivers/acpi/Kconfig >@@ -368,7 +368,7 @@ config ACPI_SBS > tristate "Smart Battery System (EXPERIMENTAL)" > depends on X86 && I2C > depends on EXPERIMENTAL >- default y >+ default n > help > This driver adds support for the Smart Battery System. > Depends on I2C (Device Drivers ---> I2C support) >_ > - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html