On Sun, Jul 09, 2006 at 07:03:23PM -0400, Brown, Len wrote:
>
> >It would be a solution to let HOTPLUG_PCI_ACPI depend on
> >(ACPI_DOCK || ACPI_DOCK=n), or the #if in
> >include/acpi/acpi_drivers.h could be changed to
> >#if defined(CONFIG_ACPI_DOCK) ||
> >(defined(CONFIG_ACPI_DOCK_MODULE) && defined(MODULE))
>
> CONFIG_HOTPLUG_PCI_ACPI requires CONFIG_ACPI_DOCK.
> There are 9 combinations.
>
> DOCK HPA
> n n ok
> n y illegal
> n m illegal
> y n ok
> y y ok
> y m ok
> m n ok
> m y illegal (subject of this thread)
> m m ok
>
> The patch below handles all these cases:
>
> DOCK HPA
> n n builds
> n y -> y,y
> n m -> m,m
> y n builds
> y y builds
> y m builds
> m n builds
> m y -> m,y
> m m builds
>
> okay?
This patch looks wrong since it allows the illegal configuration
ACPI_IBM_DOCK=y, HOTPLUG_PCI_ACPI=y/m, ACPI_DOCK=y/m.
If you select something, you have to ensure the dependencies of what you
are select'ing are fulfilled.
config HOTPLUG_PCI_ACPI
tristate "ACPI PCI Hotplug driver"
depends on ACPI && HOTPLUG_PCI
depends on !ACPI_IBM_DOCK
select ACPI_DOCK
help
...
> -Len
>
> diff --git a/drivers/pci/hotplug/Kconfig b/drivers/pci/hotplug/Kconfig
> index 222a1cc..e7c955b 100644
> --- a/drivers/pci/hotplug/Kconfig
> +++ b/drivers/pci/hotplug/Kconfig
> @@ -78,6 +78,7 @@ config HOTPLUG_PCI_IBM
> config HOTPLUG_PCI_ACPI
> tristate "ACPI PCI Hotplug driver"
> depends on ACPI && HOTPLUG_PCI
> + select ACPI_DOCK
> help
> Say Y here if you have a system that supports PCI Hotplug
> using
> ACPI.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
