On Sun, Jun 25, 2006 at 10:40:39PM +0200, Adrian Bunk wrote: > On Sun, Jun 25, 2006 at 01:13:04PM -0700, Miles Lane wrote: > > > Should I attach my entire .config file in the future? It's large enough > > that > > I try to trim it to avoid bloating people's inboxes. > > I'm often trying to reproduce compile errors, and it's always a pain in > the ass when I have to construct a complete .config based on such a > fragment instead of simply using the complete .config of the reporter. > > And people for whom a few kB would matter wouldn't subscribe to > linux-kernel... > > > Yes, that's right. It is compiled as a module. So this just needs > > a tweaked config rule, right? > > It would be a solution to let HOTPLUG_PCI_ACPI depend on > (ACPI_DOCK || ACPI_DOCK=n), or the #if in > include/acpi/acpi_drivers.h could be changed to > #if defined(CONFIG_ACPI_DOCK) || (defined(CONFIG_ACPI_DOCK_MODULE) && defined(MODULE)) > > Which one suits better the intention is better is a question Kristen has > to answer. Two weeks ago, we had: - a bug report - a detailed description how to possibly fix this issue What we did NOT have was: - any reaction by the patch author or any maintainer (although with the exception of Linus, the recipients of the problem description were exactly the same as the ones in this email) A few days later, the patch that includes this bug was included in Linus' tree. Two weeks later, the bug is still present in both latest -mm and Linus' tree. Linus, please do a git-revert a5e1b94008f2a96abf4a0c0371a55a56b320c13e cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html