On 7/7/06, Yu, Luming <luming.yu@xxxxxxxxx> wrote:
+ if (function == ACPI_WRITE) {
+ status = acpi_bus_generate_event(dev, 0x80, address);
+ atlas_input_report((u8) address);
+ } else {
Please don't use two mechanism to report one event.
For other part of code, I ACK.
Hi Luming,
Thanks for the feedback. Actually, Len had asked the same question on
this list to which I replied:
---
The event is reported to ACPI because there are legacy apps that read
/proc/acpi/event for this ASIM event. Newer apps can use the F1...
events that they can get via evdev. btw, if CONFIG_INPUT is disabled,
atlas_input_report gets dummied out and it's reported only to ACPI.
---
So to rephrase, I didn't want to break compatibility with preexisting
apps and also so that there is an event generated in the case where
CONFIG_INPUT is not used.
I guess it looks like the consensus is that acpi_bus_generate_event
must go, so I'll remove it and do some other cleanup as well and post
that.
Thanks,
jaya
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
