On 5/22/06, Pavel Machek <pavel@xxxxxx> wrote:
> + set_bit(KEY_F1 ,input_dev->keybit);
", " please... and are you sure you want it as a F1..F9 keys?
Will correct the ",", it was a typo. I picked F1 through F9 because
distributors are free to label the fascia of the panel as they wish. I
figured F1 through F9 would be a sufficiently generic selection. What
do you recommend?
> +/* button handling code */
> +static acpi_status acpi_atlas_button_setup(acpi_handle region_handle,
> + u32 function, void *handler_context, void **return_context)
> +{
> + *return_context =
> + (function != ACPI_REGION_DEACTIVATE) ? handler_context : NULL;
Too many spaces after ? I'd say.
Agreed. Will correct.
> +static struct acpi_driver atlas_acpi_driver = {
> + .name = ACPI_ATLAS_NAME,
> + .class = ACPI_ATLAS_CLASS,
> + .ids = ACPI_ATLAS_BUTTON_HID,
> + .ops = {
> + .add = atlas_acpi_button_add,
> + .remove = atlas_acpi_button_remove,
> + },
> +};
Watch that whitespace...
Done. And I'll remove that proc define.
Thanks,
jayakumar
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
