Johan Vromans wrote: > >> I'm not sure if I can do the test before May, but I try. > > Okay, I've packed it up with the rest of Rich' sources in what I've > shamelessly called acpi_sbs-20060422. You can fetch it from > http://www.squirrel.nl/pub/xfer/acpi_sbs-20060422.tar.bz2 > > Remember -- use at your own risk. I merely removed the code that > didn't compile... But it seems to work for me. > > -- Johan Hello Johan, the modules work great. Without a patched DSDT. Just out of the box. But there are still some minor flaws. I got some warnings during compile with kernel 2.6.16.13: CC [M] /usr/src/acpi_sbs-20060422/i2c-acpi-ec.o /usr/src/acpi_sbs-20060422/i2c-acpi-ec.c: In function 'acpi_ec_smb_access': /usr/src/acpi_sbs-20060422/i2c-acpi-ec.c:144: warning: 'len' may be used uninitialized in this function /usr/src/acpi_sbs-20060422/i2c-acpi-ec.c:144: warning: 'temp[0]' may be used uninitialized in this function /usr/src/acpi_sbs-20060422/i2c-acpi-ec.c:144: warning: 'temp[1]' may be used uninitialized in this function And the Makefile installed the modules in the root filesystem. I used a Makefile from an older version of Rich's package, which did the job. I've attached the file. It would be nice to have this in the kernel. I don't know if it is possible to merge the ac-adapter/battery part of the modules with the corresponding kernel modules (to provide the legacy interfaces ?). The code could then be switched with a configuration option, which also enables the rest of the code in additional modules (acpi_sbs, i2c_acpi_ec). This would simplify the configuration and reduces the need to read the kernel docs. ;-) Regards, Berthold - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
