It would help if you could point out any instances that could benefit from this. > Yup, that sounds reasonable. I confess I don't really know where > options like that live. include/acpi/platform/aclinux.h? I can Yes, that's the place. I'll add this support. Bob > -----Original Message----- > From: linux-acpi-owner@xxxxxxxxxxxxxxx [mailto:linux-acpi- > owner@xxxxxxxxxxxxxxx] On Behalf Of Bjorn Helgaas > Sent: Tuesday, April 18, 2006 3:38 PM > To: Moore, Robert > Cc: Brown, Len; linux-acpi@xxxxxxxxxxxxxxx; Andrew Morton > Subject: Re: [1/2] ACPI: make _OSI strings static > > On Tuesday 18 April 2006 16:29, Moore, Robert wrote: > > While I'm certainly all for letting the compiler do such things, if we > > are going to do something like this, I would like to convert all similar > > instances all at once, not just onesey-twosey -- just to keep everything > > consistent. > > Sure, that sounds fine. I don't want to get involved in that effort > though, because any patches I would come up with would be against the > Linux-ized source and hence less useful to you. > > > As far as the "Module Device" string, would this support not be > > appropriate for any OS that implements this feature? If so, it should be > > an OS-specific header configuration option. > > Yup, that sounds reasonable. I confess I don't really know where > options like that live. include/acpi/platform/aclinux.h? I can > dream up a patch for that if you want, but it would probably depend > on something like my first patch and it'd probably be more work for > you to integrate than for you to just do it yourself. > > > Actually, I find this even more readable: > > #define ACPI_NUM_OSI_STRINGS ACPI_ARRAY_SIZE (acpi_valid_osi_strings) > > > > and leave the existing code as: > > for (i = 0; i < ACPI_NUM_OSI_STRINGS; i++) { > > OK. - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
