On Saturday 01 April 2006 19:55, Brown, Len wrote:
> >From: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
> >
> >Print the ACPI wakeup device list on the same line as the label to make
> >"dmesg | grep ACPI" output more useful.
>
> It is a temporary hack that we expose these devices via the internal BIOS names.
> They should really be properties of devices in the device tree.
That's true. Is it an issue that this property is not yet exported
in the device tree? Probably not, because any current consumers of
this information would have to be scanning dmesg for ugly names like
these from my HP nw8240:
ACPI wakeup devices: C069 C0CE C1D1 C0DE C1D4
> Instead of updating this message, can we delete it altogether?
Sure. Andrew, can you replace
acpi-print-wakeup-device-list-on-same-line-as-label
with the following?
[ACPI] Don't print internal BIOS names of wakeup devices
The "wakeup" property of a device should be exported via the
device tree, not by a printk of an internal BIOS name.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
Index: linux-2.6/drivers/acpi/sleep/wakeup.c
===================================================================
--- linux-2.6.orig/drivers/acpi/sleep/wakeup.c 2006-02-13 15:44:33.000000000 -0700
+++ linux-2.6/drivers/acpi/sleep/wakeup.c 2006-04-03 11:00:41.000000000 -0600
@@ -155,7 +155,6 @@
if (acpi_disabled)
return 0;
- printk("ACPI wakeup devices: \n");
spin_lock(&acpi_device_lock);
list_for_each_safe(node, next, &acpi_wakeup_device_list) {
@@ -174,10 +173,8 @@
dev->wakeup.state.enabled = 1;
spin_lock(&acpi_device_lock);
}
- printk("%4s ", dev->pnp.bus_id);
}
spin_unlock(&acpi_device_lock);
- printk("\n");
return 0;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
