applied (even though it is apicdef.h, not acpidef.h:-) thanks, -Len >-----Original Message----- >From: linux-acpi-owner@xxxxxxxxxxxxxxx >[mailto:linux-acpi-owner@xxxxxxxxxxxxxxx] On Behalf Of akpm@xxxxxxxx >Sent: Tuesday, March 28, 2006 5:04 PM >To: Brown, Len >Cc: linux-acpi@xxxxxxxxxxxxxxx; akpm@xxxxxxxx; Raj, Ashok; ak@xxxxxx >Subject: [patch 24/26] x86_64: Remove unnecessary lapic >definition from acpidef.h > > >From: Ashok Raj <ashok.raj@xxxxxxxxx> > >Dont know why this exists... just happened to trip me when i >used a variable >name with lapic, and until i looked at the pre-processed >output couldnt figure >out we had a lame definition like this. > >Hope I am not breaking anything here.. > >Signed-off-by: Ashok Raj <ashok.raj@xxxxxxxxx> >Cc: Andi Kleen <ak@xxxxxx> >Signed-off-by: Andrew Morton <akpm@xxxxxxxx> >--- > > include/asm-i386/apicdef.h | 1 - > include/asm-x86_64/apicdef.h | 2 -- > 2 files changed, 3 deletions(-) > >diff -puN >include/asm-i386/apicdef.h~remove-unnecessary-lapic-definition- >from-acpidefh include/asm-i386/apicdef.h >--- >devel/include/asm-i386/apicdef.h~remove-unnecessary-lapic-defin ition-from-acpidefh 2006-03-28 14:03:07.000000000 -0800 >+++ devel-akpm/include/asm-i386/apicdef.h 2006-03-28 >14:03:07.000000000 -0800 >@@ -120,7 +120,6 @@ > */ > #define u32 unsigned int > >-#define lapic ((volatile struct local_apic *)APIC_BASE) > > struct local_apic { > >diff -puN >include/asm-x86_64/apicdef.h~remove-unnecessary-lapic-definitio n-from-acpidefh include/asm-x86_64/apicdef.h >--- >devel/include/asm-x86_64/apicdef.h~remove-unnecessary-lapic-def inition-from-acpidefh 2006-03-28 14:03:07.000000000 -0800 >+++ devel-akpm/include/asm-x86_64/apicdef.h 2006-03-28 >14:03:07.000000000 -0800 >@@ -137,8 +137,6 @@ > */ > #define u32 unsigned int > >-#define lapic ((volatile struct local_apic *)APIC_BASE) >- > struct local_apic { > > /*000*/ struct { u32 __reserved[4]; } __reserved_01; >_ >- >To unsubscribe from this list: send the line "unsubscribe >linux-acpi" in >the body of a message to majordomo@xxxxxxxxxxxxxxx >More majordomo info at http://vger.kernel.org/majordomo-info.html > - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
