applied. thanks, -Len >-----Original Message----- >From: linux-acpi-owner@xxxxxxxxxxxxxxx >[mailto:linux-acpi-owner@xxxxxxxxxxxxxxx] On Behalf Of akpm@xxxxxxxx >Sent: Tuesday, March 28, 2006 5:04 PM >To: Brown, Len >Cc: linux-acpi@xxxxxxxxxxxxxxx; akpm@xxxxxxxx; Raj, Ashok; >davej@xxxxxxxxxxxxxxxxx; kaneshige.kenji@xxxxxxxxxxxxxxxx >Subject: [patch 19/26] acpi signedness fix > > >From: Ashok Raj <ashok.raj@xxxxxxxxx> > >Local apic entries are only 8 bits, but it seemed to not be >caught with u8 >return value result in the check > >cpu_index >= NR_CPUS becomming always false. > >drivers/acpi/processor_core.c: In function `acpi_processor_get_info': >drivers/acpi/processor_core.c:483: warning: comparison is >always false due to limited range of data type > >Signed-off-by: Ashok Raj <ashok.raj@xxxxxxxxx> >Cc: "Brown, Len" <len.brown@xxxxxxxxx> >Cc: Dave Jones <davej@xxxxxxxxxxxxxxxxx> >Cc: Kenji Kaneshige <kaneshige.kenji@xxxxxxxxxxxxxxxx> >Signed-off-by: Andrew Morton <akpm@xxxxxxxx> >--- > > drivers/acpi/processor_core.c | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > >diff -puN drivers/acpi/processor_core.c~acpi-signedness-fix-2 >drivers/acpi/processor_core.c >--- devel/drivers/acpi/processor_core.c~acpi-signedness-fix-2 >2006-03-28 14:03:06.000000000 -0800 >+++ devel-akpm/drivers/acpi/processor_core.c 2006-03-28 >14:03:06.000000000 -0800 >@@ -382,7 +382,7 @@ static int acpi_processor_remove_fs(stru > > /* Use the acpiid in MADT to map cpus in case of SMP */ > #ifndef CONFIG_SMP >-#define convert_acpiid_to_cpu(acpi_id) (0xff) >+#define convert_acpiid_to_cpu(acpi_id) (-1) > #else > > #ifdef CONFIG_IA64 >@@ -395,7 +395,7 @@ static int acpi_processor_remove_fs(stru > #define ARCH_BAD_APICID (0xff) > #endif > >-static u8 convert_acpiid_to_cpu(u8 acpi_id) >+static int convert_acpiid_to_cpu(u8 acpi_id) > { > u16 apic_id; > int i; >@@ -421,7 +421,7 @@ static int acpi_processor_get_info(struc > acpi_status status = 0; > union acpi_object object = { 0 }; > struct acpi_buffer buffer = { sizeof(union >acpi_object), &object }; >- u8 cpu_index; >+ int cpu_index; > static int cpu0_initialized; > > ACPI_FUNCTION_TRACE("acpi_processor_get_info"); >@@ -466,7 +466,7 @@ static int acpi_processor_get_info(struc > cpu_index = convert_acpiid_to_cpu(pr->acpi_id); > > /* Handle UP system running SMP kernel, with no LAPIC in MADT */ >- if (!cpu0_initialized && (cpu_index == 0xff) && >+ if (!cpu0_initialized && (cpu_index == -1) && > (num_online_cpus() == 1)) { > cpu_index = 0; > } >@@ -480,7 +480,7 @@ static int acpi_processor_get_info(struc > * less than the max # of CPUs. They should be ignored _iff > * they are physically not present. > */ >- if (cpu_index >= NR_CPUS) { >+ if (cpu_index == -1) { > if (ACPI_FAILURE > (acpi_processor_hotadd_init(pr->handle, &pr->id))) { > ACPI_ERROR((AE_INFO, >_ >- >To unsubscribe from this list: send the line "unsubscribe >linux-acpi" in >the body of a message to majordomo@xxxxxxxxxxxxxxx >More majordomo info at http://vger.kernel.org/majordomo-info.html > - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
