applied. thanks, -Len >-----Original Message----- >From: akpm@xxxxxxxx [mailto:akpm@xxxxxxxx] >Sent: Tuesday, March 28, 2006 5:04 PM >To: Brown, Len >Cc: linux-acpi@xxxxxxxxxxxxxxx; akpm@xxxxxxxx; bjorn.helgaas@xxxxxx >Subject: [patch 15/26] HPET: fix ACPI memory range length handling > > >From: Bjorn Helgaas <bjorn.helgaas@xxxxxx> > >ACPI address space descriptors contain _MIN, _MAX, and _LEN. >_MIN and _MAX >are the bounds within which the region can be moved (this is >clarified in >Table 6-38 of the ACPI 3.0 spec). We should use _LEN to >determine the size >of the region, not _MAX - _MIN + 1. > >Signed-off-by: Bjorn Helgaas <bjorn.helgaas@xxxxxx> >Signed-off-by: Andrew Morton <akpm@xxxxxxxx> >--- > > drivers/char/hpet.c | 5 +---- > 1 files changed, 1 insertion(+), 4 deletions(-) > >diff -puN >drivers/char/hpet.c~hpet-fix-acpi-memory-range-length-handling >drivers/char/hpet.c >--- >devel/drivers/char/hpet.c~hpet-fix-acpi-memory-range-length-h >andling 2006-03-28 14:03:05.000000000 -0800 >+++ devel-akpm/drivers/char/hpet.c 2006-03-28 >14:03:05.000000000 -0800 >@@ -925,11 +925,8 @@ static acpi_status hpet_resources(struct > status = acpi_resource_to_address64(res, &addr); > > if (ACPI_SUCCESS(status)) { >- unsigned long size; >- >- size = addr.maximum - addr.minimum + 1; > hdp->hd_phys_address = addr.minimum; >- hdp->hd_address = ioremap(addr.minimum, size); >+ hdp->hd_address = ioremap(addr.minimum, >addr.address_length); > > if (hpet_is_known(hdp)) { > printk(KERN_DEBUG "%s: 0x%lx is busy\n", >_ > - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
