RE: [ACPI] acpi_os_wait_semaphore(): don't complain about timeout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is correct.

Unfortunately, it is one of the problems with performing a global
replace of the ACPI_DEBUG_PRINT (WARNING/ERROR) with the non-debug
ACPI_ERROR and ACPI_WARNING, and it will take some time to shake out
these kinds of issues.



> -----Original Message-----
> From: linux-acpi-owner@xxxxxxxxxxxxxxx [mailto:linux-acpi-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Bjorn Helgaas
> Sent: Friday, March 31, 2006 2:33 PM
> To: Brown, Len
> Cc: linux-acpi@xxxxxxxxxxxxxxx; Andrew Morton; Thomas Renniger
> Subject: [ACPI] acpi_os_wait_semaphore(): don't complain about timeout
> 
> The ASL Acquire operator (17.5.1 in ACPI 3.0 spec) is allowed to
> time out and return True without acquiring the semaphore.  There's
> no indication in the spec that this is an actual error, so this
> message should be debug-only, as the message for successful
acquisition
> is.
> 
> This used to be an ACPI_DEBUG_PRINT, but it was mis-classified as
> ACPI_DB_ERROR rather than ACPI_DB_MUTEX, so it got swept up in
> Thomas' recent patch to enable ACPI error messages even without
> CONFIG_ACPI_DEBUG.
> 
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
> 
> Index: work-mm5/drivers/acpi/osl.c
> ===================================================================
> --- work-mm5.orig/drivers/acpi/osl.c	2006-03-23 10:22:40.000000000 -
> 0700
> +++ work-mm5/drivers/acpi/osl.c	2006-03-31 14:40:44.000000000
-0700
> @@ -816,7 +816,7 @@
>  	}
> 
>  	if (ACPI_FAILURE(status)) {
> -		ACPI_EXCEPTION((AE_INFO, status,
> +		ACPI_DEBUG_PRINT((ACPI_DB_MUTEX,
>  				  "Failed to acquire
semaphore[%p|%d|%d], %s",
>  				  handle, units, timeout,
>  				  acpi_format_exception(status)));
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi"
in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux