akpm@xxxxxxxx <akpm@xxxxxxxx> :
[...]
> diff -puN drivers/acpi/scan.c~acpi-simplify-scanc-coding drivers/acpi/scan.c
> --- devel/drivers/acpi/scan.c~acpi-simplify-scanc-coding 2006-03-28 14:03:04.000000000 -0800
> +++ devel-akpm/drivers/acpi/scan.c 2006-03-28 14:03:04.000000000 -0800
[...]
> @@ -639,21 +631,19 @@ EXPORT_SYMBOL(acpi_bus_register_driver);
> */
> int acpi_bus_unregister_driver(struct acpi_driver *driver)
> {
> - int error = 0;
> -
> ACPI_FUNCTION_TRACE("acpi_bus_unregister_driver");
>
> - if (driver) {
> - acpi_driver_detach(driver);
> + if (!driver)
> + return_VALUE(-EINVAL);
Afaiks driver can not be NULL and no one checks the return
code of acpi_bus_unregister_driver. More cleanup in sight ?
--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
