On 30 Mar 2006 16:18:11 +0200 Andi Kleen <ak@xxxxxx> wrote: > On Thu, Mar 30, 2006 at 10:54:59PM +0900, KAMEZAWA Hiroyuki wrote: > > On 30 Mar 2006 15:41:33 +0200 > > Andi Kleen <ak@xxxxxx> wrote: > > > > > > > > Hi, > > > > > > I started to implement your suggestion now. > > > > > > But one problem I noticed and I don't see how the current sparsemem code > > > handles correctly is that it makes no attempt to handle hotadd > > > areas that cross zone boundaries. Is there code somewhere that rejects > > > them? > > > > > > > add_memory() selects a zone which pages are added, before adding memory regardless > > of its address. Now this is hard-coded. > > > > ia64 adds memory to NORMAL. > > i386 adds memory to HIGHMEM. > > x86_64 adds memory to NORMAL. > > Yes but what stops ACPI from trying to add memory that crosses > a zone? (e.g. from 2GB to 6GB) > 2GB to 6GB pages are all added to NORMAL, not DMA32. (2.6.16) If this is not sane, x86_64's add_memory should have to check address of start/end. > > > > if x86_64 people wants to add memory to DMA32 or some other zone, please add code. > > I added a check for it in the reserve hotadd code now. > great. I'll look into x86_64's add_memory() (with CONFIG_MEMORY_HOTPLUG=y) and fix it if I can. Thanks, - Kame - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
