Re: [PATCH] uacce: use sysfs_emit instead of sprintf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 2021/5/17 18:36, Greg KH wrote:
On Mon, May 17, 2021 at 06:25:37PM +0800, Kai Ye wrote:
Use the sysfs_emit to replace sprintf.

That says _what_ you did, not _why_ you are doing this.  What problem
are you solving with this change?


greg k-h

sprintf is not safe, and it not recommended to use.
sprintf does not know the PAGE_SIZE maximum of the temporary buffer
used for outputting sysfs content and it's possible to overrun the
PAGE_SIZE buffer length. so used sysfs_emit that  knows that the size
of the call situations that also ensures that no overrun is done. so use sysfs_emit to replace sprintf maybe better.

Kai Ye

[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux