On Tue, Jan 19, 2021 at 12:27:59PM +0000, Jonathan Cameron wrote: > On Fri, 8 Jan 2021 15:52:13 +0100 > Jean-Philippe Brucker <jean-philippe@xxxxxxxxxx> wrote: > > > The IOPF (I/O Page Fault) feature is now enabled independently from the > > SVA feature, because some IOPF implementations are device-specific and > > do not require IOMMU support for PCIe PRI or Arm SMMU stall. > > > > Enable IOPF unconditionally when enabling SVA for now. In the future, if > > a device driver implementing a uacce interface doesn't need IOPF > > support, it will need to tell the uacce module, for example with a new > > flag. > > > > Signed-off-by: Jean-Philippe Brucker <jean-philippe@xxxxxxxxxx> > Hi Jean-Philippe, > > A minor suggestion inline but I'm not that bothered so either way > looks good to me. No problem, I'll add the disable function Thanks, Jean