On 2020/7/30 14:13, Kai Ye wrote: > 1. delete some redundant code. > 2. modify the module author information. > > Signed-off-by: Kai Ye <yekai13@xxxxxxxxxx> Fine to me. Reviewed-by: Zhou Wang <wangzhou1@xxxxxxxxxxxxx> Thanks, Zhou > --- > Changes in V2: > deleted extra NULL pointer check in uacce_fops. > > drivers/misc/uacce/uacce.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c > index 107028e..1d09707 100644 > --- a/drivers/misc/uacce/uacce.c > +++ b/drivers/misc/uacce/uacce.c > @@ -239,17 +239,6 @@ static int uacce_fops_mmap(struct file *filep, struct vm_area_struct *vma) > > switch (type) { > case UACCE_QFRT_MMIO: > - if (!uacce->ops->mmap) { > - ret = -EINVAL; > - goto out_with_lock; > - } > - > - ret = uacce->ops->mmap(q, vma, qfr); > - if (ret) > - goto out_with_lock; > - > - break; > - > case UACCE_QFRT_DUS: > if (!uacce->ops->mmap) { > ret = -EINVAL; > @@ -541,5 +530,5 @@ subsys_initcall(uacce_init); > module_exit(uacce_exit); > > MODULE_LICENSE("GPL"); > -MODULE_AUTHOR("Hisilicon Tech. Co., Ltd."); > +MODULE_AUTHOR("HiSilicon Tech. Co., Ltd."); > MODULE_DESCRIPTION("Accelerator interface for Userland applications"); >