I have removed all instances of fastcall and FASTCALL() in kmodule directory and I still see errors: [olivares@localhost martian-full-20080407]$ make all make -C kmodule/ modules make[1]: Entering directory `/home/olivares/Download/martian-full-20080407/kmodule' make -C /lib/modules/2.6.25.3-18.fc9.x86_64/build M="/home/olivares/Download/martian-full-20080407/kmodule" modules make[2]: Entering directory `/usr/src/kernels/2.6.25.3-18.fc9.x86_64' CC [M] /home/olivares/Download/martian-full-20080407/kmodule/martian.o In file included from /home/olivares/Download/martian-full-20080407/kmodule/kmartian.h:13, from /home/olivares/Download/martian-full-20080407/kmodule/martian.c:63: /home/olivares/Download/martian-full-20080407/kmodule/mfifo.h:21: error: expected declaration specifiers or '...' before '(' token /home/olivares/Download/martian-full-20080407/kmodule/mfifo.h:21: warning: function declaration isn't a prototype /home/olivares/Download/martian-full-20080407/kmodule/mfifo.h:21: error: field 'FASTCALL' declared as a function /home/olivares/Download/martian-full-20080407/kmodule/mfifo.h:22: error: expected declaration specifiers or '...' before '(' token /home/olivares/Download/martian-full-20080407/kmodule/mfifo.h:22: warning: function declaration isn't a prototype /home/olivares/Download/martian-full-20080407/kmodule/mfifo.h:22: error: field 'FASTCALL' declared as a function /home/olivares/Download/martian-full-20080407/kmodule/mfifo.h:22: error: duplicate member 'FASTCALL' /home/olivares/Download/martian-full-20080407/kmodule/mfifo.h: In function 'mfifo_next': /home/olivares/Download/martian-full-20080407/kmodule/mfifo.h:45: error: 'struct mfifo_ops' has no member named 'wrap' /home/olivares/Download/martian-full-20080407/kmodule/mfifo.h: In function 'mfifo_put': /home/olivares/Download/martian-full-20080407/kmodule/mfifo.h:54: error: 'struct mfifo_ops' has no member named 'wrap' /home/olivares/Download/martian-full-20080407/kmodule/mfifo.h: In function 'mfifo_full': /home/olivares/Download/martian-full-20080407/kmodule/mfifo.h:62: error: 'struct mfifo_ops' has no member named 'space' /home/olivares/Download/martian-full-20080407/kmodule/mfifo.h: In function 'mfifo_get': /home/olivares/Download/martian-full-20080407/kmodule/mfifo.h:81: error: 'struct mfifo_ops' has no member named 'wrap' /home/olivares/Download/martian-full-20080407/kmodule/mfifo.h: In function 'mfifo_lastwr': /home/olivares/Download/martian-full-20080407/kmodule/mfifo.h:87: error: 'struct mfifo_ops' has no member named 'wrap' In file included from /home/olivares/Download/martian-full-20080407/kmodule/martian.c:65: /home/olivares/Download/martian-full-20080407/kmodule/marsio.h: At top level: /home/olivares/Download/martian-full-20080407/kmodule/marsio.h:8: error: expected ')' before '(' token /home/olivares/Download/martian-full-20080407/kmodule/marsio.h:9: error: expected ')' before '(' token /home/olivares/Download/martian-full-20080407/kmodule/marsio.h:10: error: expected ')' before '(' token /home/olivares/Download/martian-full-20080407/kmodule/marsio.h:11: error: expected ')' before '(' token /home/olivares/Download/martian-full-20080407/kmodule/martian.c: In function 'martian_isr': /home/olivares/Download/martian-full-20080407/kmodule/martian.c:119: error: implicit declaration of function 'mars_read_register' /home/olivares/Download/martian-full-20080407/kmodule/martian.c:131: error: implicit declaration of function 'mars_write_register' /home/olivares/Download/martian-full-20080407/kmodule/martian.c:139: error: implicit declaration of function 'mars_write_word' /home/olivares/Download/martian-full-20080407/kmodule/martian.c:160: error: implicit declaration of function 'process_stream' /home/olivares/Download/martian-full-20080407/kmodule/martian.c:160: warning: value computed is not used /home/olivares/Download/martian-full-20080407/kmodule/martian.c: In function 'martian_add': /home/olivares/Download/martian-full-20080407/kmodule/martian.c:664: warning: passing argument 2 of 'request_irq' from incompatible pointer type make[3]: *** [/home/olivares/Download/martian-full-20080407/kmodule/martian.o] Error 1 make[2]: *** [_module_/home/olivares/Download/martian-full-20080407/kmodule] Error 2 make[2]: Leaving directory `/usr/src/kernels/2.6.25.3-18.fc9.x86_64' make[1]: *** [modules] Error 2 make[1]: Leaving directory `/home/olivares/Download/martian-full-20080407/kmodule' make: *** [all] Error 2 [olivares@localhost martian-full-20080407]$ Thanks, Antonio On Wed, May 21, 2008 at 4:55 PM, HotblackDesiato <mls@xxxxxxxxxxxxxx> wrote: > > Stefan, > > in kernels >= 2.6.25 fastcall/FASTCALL() has been removed, see > http://lwn.net/Articles/269595. > > Just remove all occurrences of "fastcall" and all "FASTCALL()" macro calls > in each and every *.c and *.h file in the kmodule directory and have fun ;-) > > root@stefan2:/etc# uname -a > Linux stefan2 2.6.25.1-20080502-686 #3 Sat May 3 22:14:24 CEST 2008 i686 > GNU/Linux > root@stefan2:/etc# lsmod | grep martian > martian_dev 18196 0 > > HBD > > > Stefan Puch-3 wrote: >> >> Hello everyone, >> >> kernel 2.6.25 is released a few weeks and the martian sourcecode will need >> another patch to compile again. >> ... >> >> @Alex >> Are you still improving / maintaining your source code or do you have any >> time >> to fix it (or did you already buy a new laptop with another modem >> chipset)? >> >> Best regards >> >> Stefan Puch >> > > -- > View this message in context: http://www.nabble.com/Another-Patch-will-be-needed-for-kernel-version-2.6.25-tp17021760p17378435.html > Sent from the Linux Winmodem Support - Discussion mailing list archive at Nabble.com. > >