ESC meeting minutes: 2025-03-13

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Present:
  + Caolan, Cloph, Heiko, Hossein, Ilmari, Jonathan, Regina, Olivier, Stephan, Michael S, Xisco, Miklos

* Completed Action Items:

* Pending Action Items:
  + bump the clang in LODE to version 18 (Hossein)
    + in progress
      https://gerrit.libreoffice.org/c/lode/+/182317
  + print preview is dark on macOS, file issue for Heiko (Cloph)

* Release Engineering update (Cloph)
  + 24.8.6 rc2 next week
  + 25.2.2 rc2 next week
    + problem with the theming change
      + users may want to change the system theme to light, even if the system theme is dark
      + this may result in black-on-black rendering
      + much improved, but still a problem
      + not fully fixed
      + nominally the bug is fixed, the remaining parts still need addressing
      + LibreOffice Themes handled in META bug 125823
  + proposed new expert preference for macOS only in the following patch (Patrck):
    https://gerrit.libreoffice.org/c/core/+/182740
    does preference name and patch need to be changed?
    "IgnoreKeysWhenScrollingWithTrackpadOrMagicMouse"
    include in 25.2.2 or wait until 25.3.3?
    + expert option: name is not too important (Cloph)
    + no strong preference either way (Heiko)
    + related: preferences vs settings rename on the UI (Cloph)
      + direct problem: help was not updated
        => will update help (Patrick)
  + https://bugs.documentfoundation.org/show_bug.cgi?id=156855 (handling native macos light/dark mode changes) now fixed on macOS (Patrick)
    macOS fix maybe useful for Windows or Linux?
    backport non-themes part of macOS fix to 24.8.6?
    + fine to have it backported (Cloph)
      + though the problem is less visible there
      + it can be reproduced, but the workspace color is light by default, so it mostly doesn't happen (unless the color is customized)
    + if this is not visible there too much, would prefer to not backport, to play is safe (Xisco)
      => suggest to not backport (all)
    + related: tdf#165266 "default Automatic Appearance theme Light and dark mode Radio Button set opposite to System sets unusable colors of background and typeface (comment 5)" (Cloph)
      + much improved now, could use further work

* Documentation (Olivier)
    + Helpcontents2
       + Update on page numbering (G. Kelemen)
       + Updates and fixes (J. Sanz)
       + on hyphenation (L. Nemetz)
       + Contents on Data Provider (ohallot)
    + Guides
        + Team working on Guides updates

    + Bugzilla Documentation statistics
        217(217) bugs open
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
           created     6(3)     17(2)     122(-2)    308(-8)
         commented     9(3)     31(1)     122(-13)   903(-28)
          resolved     4(3)     11(2)      32(0)     181(-3)
    + top 10 contributors:
          Olivier Hallot made 37 changes in 1 month, and 391 changes in 1 year
          Ilmari Lauhakangas made 9 changes in 1 month, and 162 changes in 1 year
          Bogdan B made 7 changes in 1 month, and 248 changes in 1 year
          m.a.riosv made 5 changes in 1 month, and 29 changes in 1 year
          Dione Maddern made 4 changes in 1 month, and 121 changes in 1 year
          Rafael Lima made 4 changes in 1 month, and 9 changes in 1 year
          Robert Großkopf made 4 changes in 1 month, and 5 changes in 1 year
          Dieter made 3 changes in 1 month, and 29 changes in 1 year
          Kaganski, Mike made 3 changes in 1 month, and 86 changes in 1 year
          Alex Thurgood made 1 changes in 1 month, and 1 changes in 1 year

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        228(228) (topicUI) bugs open, 17(17) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week   1 month    3 months   12 months
             added      6(3)      9(0)      10(0)       19(0)
         commented     45(8)    100(-14)   259(-4)    1338(-46)
           removed      0(0)      0(0)       1(0)       12(0)
          resolved      6(-1)    15(2)      41(-1)     219(0)
    + top 10 contributors:
          Heiko Tietze made 46 changes in 1 month, and 677 changes in 1 year
          Eyal Rozenberg made 34 changes in 1 month, and 212 changes in 1 year
          Vernon, Stuart Foote made 28 changes in 1 month, and 399 changes in 1 year
          Ilmari Lauhakangas made 18 changes in 1 month, and 171 changes in 1 year
          Karthik Godha made 15 changes in 1 month, and 15 changes in 1 year
          Dieter made 7 changes in 1 month, and 104 changes in 1 year
          Werner Tietz made 7 changes in 1 month, and 12 changes in 1 year
          Balazs Varga made 6 changes in 1 month, and 13 changes in 1 year
          Roman Kuznetsov made 5 changes in 1 month, and 60 changes in 1 year
          Radish made 5 changes in 1 month, and 5 changes in 1 year
    + [Bug 165684] FILEOPEN .csv
    + [Bug 165680] Need ability to control alignment of line numbering
    + [Bug 165679] Data Provider: Rename "Apply" button to "Preview"
    + [Bug 165614] A value being a date or a time must not be considered formatting
    + [Bug 165616] Insert Row/Column buttons should allow for repeating last action

* Crash testing (Caolan)
    + 143(-18) import failure, 31(+1) export failures
      - https://wiki.documentfoundation.org/Development/Crashtesting
      - new fix https://gerrit.libreoffice.org/c/core/+/182743 for a CellAttributeHelper crash
    + 2 coverity issues
    + 3 ossfuzz issues
      - 2 timeouts, 1 crash

* Crash Reporting (from crashreport.libreoffice.org) (Xisco)
    + 24.8.5.2    8742(+4919)
    + 25.2.0.2    183(+4)
    + 25.2.0.3    19962(+3409)
    + 25.2.1.2    4330(+3022)

    https://crashreport.libreoffice.org/stats/signature/SdrDragResize::MoveSdrDrag(Point%20const%20&)
    - New in 25.2
    - Code added in 86cd6036273a9031212e131141c03ed4e16e011b -> Sahil?
    - https://bugs.documentfoundation.org/show_bug.cgi?id=159543

* Mentoring (Hossein)
  + Reviewed submissions from newcomers
  + Discussed GSoC ideas with volunteers
          committer...   1 week     1 month     3 months     12 months
                  open      81(8)      149(12)     155(15)       155(15)
               reviews     410(-2)    1620(-12)   3542(-128)   13522(20)
                merged     236(-54)   1217(-49)   3147(-197)   14144(-27)
             abandoned      18(5)       82(-3)     180(4)        728(0)
           own commits     127(-79)    795(-45)   2077(-110)    9978(-63)
        review commits      47(5)      205(-2)     596(-18)     2988(-36)
        contributor...   1 week      1 month      3 months     12 months
                  open      44(-741)   1120(0)      1126(-9)      1126(-9)
               reviews     738(-126)   3084(-118)   7466(-372)   31108(-74)
                merged      17(-12)     117(-12)     308(-18)     1390(-18)
             abandoned      18(8)        62(9)       206(9)        477(13)
           own commits      21(6)        83(2)       244(-10)     1270(-19)
        review commits       0(0)         0(0)         0(0)          0(0)
    + easyHack statistics:
       needsDevEval 9(9)   needsUXEval 1(1)   cleanup_comments 352(352)
       total 426(426)   assigned 37(37)   open 351(351)
    + top 10 contributors:
          Simon Chenery made 16 patches in 1 month, and 30 patches in 1 year
          Rashesh Padia made 6 patches in 1 month, and 17 patches in 1 year
          Bogdan B made 6 patches in 1 month, and 297 patches in 1 year
          Rahul Anand made 5 patches in 1 month, and 5 patches in 1 year
          Armin Le Grand (allotropia) made 5 patches in 1 month, and 43 patches in 1 year
          Mohamed Ali made 3 patches in 1 month, and 10 patches in 1 year
          Karthik Godha made 3 patches in 1 month, and 3 patches in 1 year
          Juan C. Sanz made 2 patches in 1 month, and 2 patches in 1 year
          Pierre Vacher made 2 patches in 1 month, and 5 patches in 1 year
          Ismael Olea made 2 patches in 1 month, and 2 patches in 1 year
    + top 10 reviewers:
          Weghorn, Michael made 186 review comments in 1 month, and 504 in 1 year
          Christian Lohmaier made 140 review comments in 1 month, and 752 in 1 year
          Adolfo Jayme Barrientos made 122 review comments in 1 month, and 1080 in 1 year
          Xisco Fauli made 102 review comments in 1 month, and 800 in 1 year
          Caolán McNamara made 98 review comments in 1 month, and 1234 in 1 year
          Vajna, Miklos made 90 review comments in 1 month, and 1142 in 1 year
          Ilmari Lauhakangas made 90 review comments in 1 month, and 750 in 1 year
          Thorsten Behrens made 90 review comments in 1 month, and 676 in 1 year
          Hossein   made 82 review comments in 1 month, and 306 in 1 year
          allotropia jenkins made 70 review comments in 1 month, and 452 in 1 year
    + Patches automatically abandoned:
        tdf#114441 sal_uLong to better integer type ( Rafał Dobrakowski )
            - https://gerrit.libreoffice.org/#/c/166007
        tdf#114441 sal_uLong to better integer type ( Rafał Dobrakowski )
            - https://gerrit.libreoffice.org/#/c/170065
        CanvasExtractBitmapData(), CanvasCairoExtractBitmapData() from vcl to canvas ( Chris Sherlock )
            - https://gerrit.libreoffice.org/#/c/174098
        vcl: flatten BitmapWriteAccess::CopyScanline() functions ( Chris Sherlock )
            - https://gerrit.libreoffice.org/#/c/174129
        vcl: migrate StretchAndConvert() to BitmapBuffer.cxx ( Chris Sherlock )
            - https://gerrit.libreoffice.org/#/c/176954
        vcl: rename static functions in bmpfast.cxx ( Chris Sherlock )
            - https://gerrit.libreoffice.org/#/c/176960
        vcl: migrate ImplFastCopyScanline() to BitmapBuffer::FastCopyScanline() ( Chris Sherlock )
            - https://gerrit.libreoffice.org/#/c/177007
        tdf#163486: PVS V1028 Possible overflow. Consider casting operands, ( Bogdan Buzea )
            - https://gerrit.libreoffice.org/#/c/177083
        tdf#163486: PVS V1028 Possible overflow. Consider casting operands, ( Bogdan Buzea )
            - https://gerrit.libreoffice.org/#/c/177084
        tdf#163486: PVS V1028 Possible overflow. Consider casting operands, ( Bogdan Buzea )
            - https://gerrit.libreoffice.org/#/c/177086
        tdf#163486: PVS V1028 Possible overflow. Consider casting operands, ( Bogdan Buzea )
            - https://gerrit.libreoffice.org/#/c/177101
        tdf#163486: PVS V1028 Possible overflow. Consider casting operands, ( Bogdan Buzea )
            - https://gerrit.libreoffice.org/#/c/177104
        vcl: move bitmap.hxx to include/vcl/bitmap/Bitmap.hxx ( Chris Sherlock )
            - https://gerrit.libreoffice.org/#/c/177132
        vcl: migrate ImplUpdateSeparaters() to Edit class ( Chris Sherlock )
            - https://gerrit.libreoffice.org/#/c/178994
        vcl: SvxIconChoiceControlEntry -> IconChoiceControlEntry ( Chris Sherlock )
            - https://gerrit.libreoffice.org/#/c/179210
        vcl: SvtIconChoiceCtrl -> IconChoiceCtrl ( Chris Sherlock )
            - https://gerrit.libreoffice.org/#/c/179211
        vcl: move IconChoiceCtrl and IconChoiceCtrlEntry to seperate include files ( Chris Sherlock )
            - https://gerrit.libreoffice.org/#/c/179222
        remove sw::util::item_cast (mostly duplicates StaticWhichCast) ( Bjoern Michaelsen )
            - https://gerrit.libreoffice.org/#/c/179491
        xmlsecurity : use more static constexpr instead of static vector ( Arnaud Versini )
            - https://gerrit.libreoffice.org/#/c/179580
        wip: crashtesting: reload of rtf export of forum-de2-13462.odt Invalid read ( Caolán McNamara )
            - https://gerrit.libreoffice.org/#/c/179778
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          shrey_223
          Jan Rheinländer
          Karthik Godha
           langty
          Kukee Thoo

* GSoC (Ilmari)
  + https://developers.google.com/open-source/gsoc/timeline
  + Add your ideas: https://wiki.documentfoundation.org/Development/GSoC/Ideas
    + need more, better ideas (Hossein)
      + with mentors who have the time
    + if your ideas are near the top of the page, you get more interested students (Ilmari)
      + Some that took attention of people were actually near the bottom (Hossein)
  + Next step: applications will open on 24th March

* Commit Access

* Developer Certification (Stephan/Miklos/László/Gabriel)
  + resting since: 18 weeks (limit: 20 weeks)

* Jenkins / CI update (Cloph)
gerrit_android_aarch64     jobs: 115 ok: 115 ko:   0 fail ratio: 0.00% mean_ok:   7 (  9) median_ok:   5 (  6)
gerrit_android_arm         jobs: 116 ok: 114 ko:   1 fail ratio: 0.86% mean_ok:   7 (  8) median_ok:   5 (  6)
gerrit_android_x86         jobs: 115 ok: 115 ko:   0 fail ratio: 0.00% mean_ok:   7 (  8) median_ok:   5 (  6)
gerrit_android_x86_64      jobs: 116 ok: 115 ko:   1 fail ratio: 0.86% mean_ok:   7 (  8) median_ok:   5 (  6)
gerrit_linux_clang_dbgutil jobs: 239 ok: 197 ko:  39 fail ratio: 16.32% mean_ok:  35 ( 36) median_ok:  35 ( 35)
gerrit_linux_gcc_release   jobs: 260 ok: 226 ko:  29 fail ratio: 11.15% mean_ok:  20 ( 20) median_ok:  19 ( 19)
gerrit_mac                 jobs: 238 ok: 220 ko:  15 fail ratio: 6.30% mean_ok:  48 ( 48) median_ok:  44 ( 44)
gerrit_windows             jobs: 246 ok: 217 ko:  27 fail ratio: 10.98% mean_ok:  35 ( 35) median_ok:  34 ( 34)
gerrit_master_ml           jobs: 275 ok: 187 ko:  80 fail ratio: 29.09% mean_ok:  66 ( 66) median_ok:  64 ( 64)
gerrit_master              jobs:  30 ok:  19 ko:  11 fail ratio: 36.67% mean_ok:  51 ( 51) median_ok:  44 ( 44)
gerrit_master_seq          jobs: 245 ok: 168 ko:  69 fail ratio: 28.16% mean_ok:  67 ( 67) median_ok:  64 ( 64)
   + tests that failed more than twice in last seven days
      3 UITest_sw_ui_frmdlg                gerrit_linux_clang_dbgutil
      4 UITest_sw_sidebar                gerrit_linux_clang_dbgutil
      5 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil
      5 UITest_impress_tests                gerrit_linux_clang_dbgutil
      6 aborted by jenkins job timeout                gerrit_windows
  + this week everything went fine (Cloph)
  + arm64 Windows tinderbox status?

      + pdfium is currently broken there, what to do?

      + just disable/hide the problem or leave it red?

      + https://gerrit.libreoffice.org/c/core/+/182856 for the disable way (Miklos)

      + maybe can take a look (Stephan)

  + do we have a linux arm64 tinderbox? (Hossein)
    + no, but should work, distros do this (Cloph)
    + the flatpack builds also do this (Stephan)
  + native windows arm64 builds (Cloph)
    + newer VS results in an openssl miscompile, unfortunately
    + upgrade carefully (17.10 LTSC is fine, 17.12.x or 17.13 as well as preview fail)

* What’s cooking (Miklos)
  + A11y update (Michael W)
    + (attending CSUN Assistive Technology Conference in Anaheim)
  + RTL/CTL/CJK update (Jonathan)
    + tdf#80596: FILEOPEN DOC: Implemented sprmPDxc* LR indentation
      + https://bugs.documentfoundation.org/show_bug.cgi?id=80596
    + tdf#70102: RTL: Mirrored toolbar button icons don't always look suitable
      + https://bugs.documentfoundation.org/show_bug.cgi?id=70102
      + Added code support for icon-themes to provide RTL graphics for UNO commands
      + Bug still open, pending graphics work

* QA update (Xisco)
    + UNCONFIRMED: 1555 (+22)
        + enhancements: 402  (+2)
        + needsUXEval: 7 (+0)
        + haveBackTrace: 13 (+0)
        + needsDevAdvice: 48 (-1)
        + documentation:  2 (+0)
        + android:  0 (+0)
        + iOS:  0 (+0)
        + Online:  7 (+0)

    + Most pressing bugs:
     New:

    None


    + New high severity bugs of the week:

    None


* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +121  +8 (-86) overall)
      many thanks to the top bug squashers:
       Julien Nabet            9
       V Stuart Foote          6
       Balázs Varga (allotropia) 5
       Caolán McNamara         5
       Heiko Tietze            5
       Mike Kaganski           5
       Buovjaga                4
       Olivier Hallot          4
       Jonathan Clark          3
       Karthik                 3

    + top 10 bugs reporters:
       Gabor Kelemen (allotropia) 10
       Rafael Lima             7
       Liz Lee                 6
       Eyal Rozenberg          5
       Olivier Hallot          4
       Aron Budea              3
       Dastagiri               3
       Xisco Faulí             3
       Buovjaga                2
       Gerald Pfeifer          2

    + top 10 bugs fixers:
       Caolán McNamara         5
       Olivier Hallot          4
       Karthik Godha           3
       Patrick Luby            3
       Balazs Varga            2
       Heiko Tietze            2
       Justin Luth             2
       Le Grand, Armin         2
       Michael Stahl           2
                               1

    + top 10 bugs confirmers:
       m.a.riosv               19
       Raal                    9
       *UNKNOWN*               6
       Heiko Tietze            5
       Ilmari Lauhakangas      5
       Vernon, Stuart Foote    5
       Xisco Fauli             5
       Olivier Hallot          4
       yosi3260+libre@xxxxxxxxx 3
       Aron Budea              2


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   +

     done by:
        Ilmari Lauhakangas     3
        Xisco Fauli            3
        libre                  2
        Aron Budea             1
        huanhuanbeibei         1


* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   +

     done by:
        Ilmari Lauhakangas     3
        Xisco Fauli            3
        Aron Budea             1
        libre                  1
        Olivier Hallot         1


* all bugs tagged with 'regression'
   + 1256(-7) bugs open of 13983(+16) total 23(+0) high prio.

     done by:
        Ilmari Lauhakangas     3
        Xisco Fauli            2
        libre                  1
        Raal                   1
        Jim Raykowski          1
        nobu                   1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Writer        - 9(+0)
     Calc          - 6(+0)
     LibreOffice   - 4(+0)
     Impress       - 2(+0)
     Installation  - 1(+0)
     UI            - 1(+0)

   by OS:
     All           - 17(+0)
     Linux         - 4(+0)
     Mac OS X      - 0(+0)
     Windows       - 2(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 421(+0)
     Calc                     - 241(-2)
     Impress                  - 128(-3)
     LibreOffice              - 57(-1)
     Draw                     - 47(-1)
     Writer: docx filter      - 45(+0)
     Crashes                  - 44(+0)
     Base                     - 36(+0)
     Borders                  - 35(+0)
     UI                       - 35(-3)
     Writer: perf             - 34(-1)
     Writer: other filter     - 30(+1)
     Chart                    - 27(+0)
     filters and storage      - 26(+1)
     Printing and PDF export  - 24(-1)
     RTL                      - 23(+1)
     BASIC                    - 19(+0)
     Writer: doc filter       - 18(+0)
     graphics stack           - 13(+0)
     Formula Editor           - 11(+1)
     framework                - 3(+0)
     sdk                      - 3(+0)
     Extensions               - 2(+0)
     Installation             - 2(+0)
     Linguistic               - 2(+0)



[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux