Re: Minor whitespace changes relating to lines of code that are being changed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





The devil is in the details. Michael is right that there are lines where only spaces have been changed, but his first comment didn't show exactly the lines he was suggesting for correction, maybe that is why he was unwittingly opening old wounds. Chris' e-mail shows for me that the motivation of the experienced and valuable contributor is at risk. Or more contributors, including Michael now.

The right solution will be one where we don't get any more wounds, but who knows what it is. That is why I have corrected the 5-6 lines, where there were only space differences, hoping the best!

Thanks for your commit and reviews!

Best regards,
László

For the record, Michael’s contributions are amazing and I have been fascinated by his changes to accessibility - what he is doing is more valuable to the project than anyone can imagine. 

I also want to make to publicly thank Michael for reviewing all my small changes. I very, very much appreciate his help. I also appreciate the help of everyone else who has reviewed my changes, including Noel and Tomaz. Michael has been nothing but respectful and helpful in all his interactions with me. 

For what it's worth, I’m trying to make small changes that have limited impact on the codebase and that make bisecting easy if I did something wrong. After my last large scale change, I realise I made some errors and before I had a chance to even look into the issues they had been fixed by Caolan, and for that I’m very grateful. I was told that it caused huge problems and stopped paid contributors from progressing their work, and I’m trying my very best to ensure this doesn’t happen again. 

It also makes me quite anxious. If anything I have done or said because of my anxiety has offended anyone, then I very much regret this and apologise unreservedly to the people I have offended. 

Chris

[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux