New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1641354:  Uninitialized members  (UNINIT_CTOR)
/sc/source/core/data/validat.cxx: 429 in ScValidationData::DoError(weld::Window *, const rtl::OUString &, const ScAddress &, const std::function<void (bool)> &) const::[lambda(int) (instance 1)]::lambda(const [lambda(int) (instance 1)]&)()


________________________________________________________________________________________________________
*** CID 1641354:  Uninitialized members  (UNINIT_CTOR)
/sc/source/core/data/validat.cxx: 429 in ScValidationData::DoError(weld::Window *, const rtl::OUString &, const ScAddress &, const std::function<void (bool)> &) const::[lambda(int) (instance 1)]::lambda(const [lambda(int) (instance 1)]&)()
423                 xBox->set_default_response(RET_CANCEL);
424                 break;
425             default:
426                 break;
427         }
428     
>>>     CID 1641354:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "this" is not initialized in this constructor nor in any functions that it calls.
429         xBox->runAsync(xBox, [this, callback](sal_Int32 result)
430                        { callback(eErrorStyle == SC_VALERR_STOP || result == RET_CANCEL); });
431     }
432     
433     bool ScValidationData::IsDataValidCustom(
434             const OUString& rTest,

** CID 1641353:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/sw/source/core/docnode/node.cxx: 143 in AttrSetHandleHelper::SetParent(std::shared_ptr<const SwAttrSet> &, const SwContentNode &, const SwFormat *, const SwFormat *)()


________________________________________________________________________________________________________
*** CID 1641353:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/sw/source/core/docnode/node.cxx: 143 in AttrSetHandleHelper::SetParent(std::shared_ptr<const SwAttrSet> &, const SwContentNode &, const SwFormat *, const SwFormat *)()
137             aNewSet.Put( aAnyFormatColl );
138     
139             if ( pConditionalFormat != pParentFormat )
140             {
141                 ProgName sTmp;
142                 SwStyleNameMapper::FillProgName( pConditionalFormat->GetName(), sTmp, SwGetPoolIdFromName::TxtColl );
>>>     CID 1641353:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>>     "sTmp" is copied in a call to copy assignment "operator =", when it could be moved instead.
143                 sVal = sTmp;
144             }
145     
146             const SfxStringItem aFormatColl( RES_FRMATR_CONDITIONAL_STYLE_NAME, sVal.toString() );
147             aNewSet.Put( aFormatColl );
148         }

** CID 1641352:  Uninitialized members  (UNINIT_CTOR)
/sc/source/core/data/validat.cxx: 429 in ScValidationData::DoError(weld::Window *, const rtl::OUString &, const ScAddress &, const std::function<void (bool)> &) const::[lambda(int) (instance 1)]::lambda([lambda(int) (instance 1)]&&)()


________________________________________________________________________________________________________
*** CID 1641352:  Uninitialized members  (UNINIT_CTOR)
/sc/source/core/data/validat.cxx: 429 in ScValidationData::DoError(weld::Window *, const rtl::OUString &, const ScAddress &, const std::function<void (bool)> &) const::[lambda(int) (instance 1)]::lambda([lambda(int) (instance 1)]&&)()
423                 xBox->set_default_response(RET_CANCEL);
424                 break;
425             default:
426                 break;
427         }
428     
>>>     CID 1641352:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "this" is not initialized in this constructor nor in any functions that it calls.
429         xBox->runAsync(xBox, [this, callback](sal_Int32 result)
430                        { callback(eErrorStyle == SC_VALERR_STOP || result == RET_CANCEL); });
431     }
432     
433     bool ScValidationData::IsDataValidCustom(
434             const OUString& rTest,


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/libreoffice?tab=overview