New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1637056:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/vcl/inc/pdf/COSWriter.hxx: 50 in vcl::pdf::COSWriter::COSWriter(vcl::EncryptionParams, const std::shared_ptr<vcl::pdf::IPDFEncryptor> &)()


________________________________________________________________________________________________________
*** CID 1637056:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/vcl/inc/pdf/COSWriter.hxx: 50 in vcl::pdf::COSWriter::COSWriter(vcl::EncryptionParams, const std::shared_ptr<vcl::pdf::IPDFEncryptor> &)()
44         }
45     
46     public:
47         COSWriter(EncryptionParams aParams = EncryptionParams(),
48                   std::shared_ptr<IPDFEncryptor> const& pPDFEncryptor = nullptr)
49             : mpPDFEncryptor(pPDFEncryptor)
>>>     CID 1637056:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>>     "aParams" is copied in call to copy constructor "vcl::EncryptionParams", when it could be moved instead.
50             , maParams(aParams)
51             , maLine(1024)
52             , mrBuffer(maLine)
53         {
54         }
55     

** CID 1637055:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/vcl/inc/pdf/COSWriter.hxx: 59 in vcl::pdf::COSWriter::COSWriter(rtl::OStringBuffer &, vcl::EncryptionParams, const std::shared_ptr<vcl::pdf::IPDFEncryptor> &)()


________________________________________________________________________________________________________
*** CID 1637055:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/vcl/inc/pdf/COSWriter.hxx: 59 in vcl::pdf::COSWriter::COSWriter(rtl::OStringBuffer &, vcl::EncryptionParams, const std::shared_ptr<vcl::pdf::IPDFEncryptor> &)()
53         {
54         }
55     
56         COSWriter(OStringBuffer& rBuffer, EncryptionParams aParams = EncryptionParams(),
57                   std::shared_ptr<IPDFEncryptor> const& pPDFEncryptor = nullptr)
58             : mpPDFEncryptor(pPDFEncryptor)
>>>     CID 1637055:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>>     "aParams" is copied in call to copy constructor "vcl::EncryptionParams", when it could be moved instead.
59             , maParams(aParams)
60             , mrBuffer(rBuffer)
61         {
62         }
63     
64         void startObject(sal_Int32 nObjectID)


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DMX_9_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtrwvnS2JtwIe0AonOVX4JlkrrLbzvy4nh4s2UAdLC7ajuQKiQCg-2BK64fCbv6y4l9q39Trlqm34KXU8PeZwhsuEUWJ-2Fu-2BvboW1LGGBgXDcckmF4957JXZ6vr6FuU8qTG-2BrEExu61eKLzGtrfm4cvDfYyn1etYXhKvJWBxu-2BUFtPU0-3D