New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
6 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1636674:    (COPY_INSTEAD_OF_MOVE)
/vcl/inc/jsdialog/jsdialogregister.hxx: 31 in jsdialog::WidgetRegister<VclPtr<vcl::Window>>::Remember(const rtl::OUString &, VclPtr<vcl::Window>)()
/vcl/inc/jsdialog/jsdialogregister.hxx: 31 in jsdialog::WidgetRegister<std::shared_ptr<jsdialog::WidgetRegister<weld::Widget *>>>::Remember(const rtl::OUString &, std::shared_ptr<jsdialog::WidgetRegister<weld::Widget *>>)()


________________________________________________________________________________________________________
*** CID 1636674:    (COPY_INSTEAD_OF_MOVE)
/vcl/inc/jsdialog/jsdialogregister.hxx: 31 in jsdialog::WidgetRegister<VclPtr<vcl::Window>>::Remember(const rtl::OUString &, VclPtr<vcl::Window>)()
25         void Forget(const OUString& rId);
26         T Find(const OUString& rId);
27     };
28     
29     template <class T> void WidgetRegister<T>::Remember(const OUString& nWindowId, T pMenu)
30     {
>>>     CID 1636674:    (COPY_INSTEAD_OF_MOVE)
>>>     "pMenu" is copied in a call to copy assignment "operator =", when it could be moved instead.
31         Map()[nWindowId] = pMenu;
32     }
33     
34     template <class T> void WidgetRegister<T>::Forget(const OUString& nWindowId)
35     {
36         auto it = Map().find(nWindowId);
/vcl/inc/jsdialog/jsdialogregister.hxx: 31 in jsdialog::WidgetRegister<std::shared_ptr<jsdialog::WidgetRegister<weld::Widget *>>>::Remember(const rtl::OUString &, std::shared_ptr<jsdialog::WidgetRegister<weld::Widget *>>)()
25         void Forget(const OUString& rId);
26         T Find(const OUString& rId);
27     };
28     
29     template <class T> void WidgetRegister<T>::Remember(const OUString& nWindowId, T pMenu)
30     {
>>>     CID 1636674:    (COPY_INSTEAD_OF_MOVE)
>>>     "pMenu" is copied in a call to copy assignment "operator =", when it could be moved instead.
31         Map()[nWindowId] = pMenu;
32     }
33     
34     template <class T> void WidgetRegister<T>::Forget(const OUString& nWindowId)
35     {
36         auto it = Map().find(nWindowId);

** CID 1636673:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/cui/source/tabpages/tpbitmap.cxx: 790 in SvxBitmapTabPage::ClickImportHdl(weld::Button &)()


________________________________________________________________________________________________________
*** CID 1636673:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/cui/source/tabpages/tpbitmap.cxx: 790 in SvxBitmapTabPage::ClickImportHdl(weld::Button &)()
784                     break;
785             }
786     
787             pDlg.disposeAndClear();
788     
789             if( !nError )
>>>     CID 1636673:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>>     "aGraphic" is passed-by-value as parameter to "GraphicObject::GraphicObject(Graphic)" when it could be moved instead.
790                 AddBitmap(aGraphic, aName);
791         }
792         else
793         {
794             // graphic couldn't be loaded
795             std::unique_ptr<weld::Builder> xBuilder(Application::CreateBuilder(pDialogFrameWeld, u"cui/ui/querynoloadedfiledialog.ui"_ustr));


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3D1OYE_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGttHr37mbt-2BUT1HlZo6yIXFj6FNF2x67cjHlQI1OiXTgaIGxqQ505zIwFV60l8qbXBpE2665OkhNRpkHZIPhfLucbC2vlYfYyhtOBf5E1sUliR67Wa11LWaZnuWLi-2FvRLuabIVK-2B12-2BTI4SGfF2gEskRryYSaNBAdbSdq97-2FAxXeo-3D