New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
8 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1634530:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/editeng/source/items/frmitems.cxx: 4395 in SvxBrushItem::PutValue(const com::sun::star::uno::Any &, unsigned char)()


________________________________________________________________________________________________________
*** CID 1634530:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/editeng/source/items/frmitems.cxx: 4395 in SvxBrushItem::PutValue(const com::sun::star::uno::Any &, unsigned char)()
4389                 if (!aGraphic.IsNone())
4390                 {
4391                     maStrLink.clear();
4392     
4393                     ASSERT_CHANGE_REFCOUNTED_ITEM;
4394                     std::unique_ptr<GraphicObject> xOldGrfObj(std::move(xGraphicObject));
>>>     CID 1634530:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>>     "aGraphic" is passed-by-value as parameter to "GraphicObject::GraphicObject(Graphic)" when it could be moved instead.
4395                     xGraphicObject.reset(new GraphicObject(aGraphic));
4396                     ApplyGraphicTransparency_Impl();
4397                     xOldGrfObj.reset();
4398     
4399                     if (eGraphicPos == GPOS_NONE)
4400                     {

** CID 1634529:  Concurrent data access violations  (MISSING_LOCK)
/scripting/source/stringresource/stringresource.cxx: 528 in stringresource::StringResourceImpl::implScanIdForNumber(std::unique_lock<std::mutex> &, const rtl::OUString &)()


________________________________________________________________________________________________________
*** CID 1634529:  Concurrent data access violations  (MISSING_LOCK)
/scripting/source/stringresource/stringresource.cxx: 528 in stringresource::StringResourceImpl::implScanIdForNumber(std::unique_lock<std::mutex> &, const rtl::OUString &)()
522             }
523             else
524                 break;
525         }
526     
527         if( m_nNextUniqueNumericId < nNumber + 1 )
>>>     CID 1634529:  Concurrent data access violations  (MISSING_LOCK)
>>>     Accessing "this->m_nNextUniqueNumericId" without holding lock "stringresource::StringResourceImpl.m_aMutex". Elsewhere, "stringresource::StringResourceImpl.m_nNextUniqueNumericId" is written to with "StringResourceImpl.m_aMutex" held 2 out of 3 times.
528             m_nNextUniqueNumericId = nNumber + 1;
529     }
530     
531     sal_Int32 StringResourceImpl::getUniqueNumericId(  )
532     {
533         std::unique_lock aGuard( m_aMutex );


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DCkwL_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtO-2FXERqmxnU7o0OgR-2FcckYlreRK1E3CGGh8cDmoE-2F7VuRdbHQz2jwCrA70zU9azebGw78F6gz0PR1bG7-2FGa0Alr3SLMNf6luepiYLPT5gHiexVwp7y9Z8bhzQXDSiDfamd-2Flmbv2IOw7stoDgkQzxA0rdp8CMeOhJ-2F6dxmY4y5bI-3D