New Defects reported by Coverity Scan for LibreOffice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

6 new defect(s) introduced to LibreOffice found with Coverity Scan.
91 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 6 of 6 defect(s)


** CID 1633781:  High impact quality  (GLOBAL_INIT_ORDER)


________________________________________________________________________________________________________
*** CID 1633781:  High impact quality  (GLOBAL_INIT_ORDER)
/desktop/source/lib/lokclipboard.cxx: 23 in ()
17     #include <com/sun/star/uno/XComponentContext.hpp>
18     
19     using namespace css;
20     using namespace css::uno;
21     
22     /* static */ osl::Mutex LOKClipboardFactory::gMutex;
>>>     CID 1633781:  High impact quality  (GLOBAL_INIT_ORDER)
>>>     The constructor of global object "gClipboards" itself makes use of global object "tools::gDeinitDeleteList" defined in another compilation unit.  The order of construction is unspecified, so "gClipboards" might be created before "tools::gDeinitDeleteList" is available.
23     static tools::DeleteOnDeinit<std::unordered_map<int, rtl::Reference<LOKClipboard>>> gClipboards{};
24     
25     rtl::Reference<LOKClipboard> LOKClipboardFactory::getClipboardForCurView()
26     {
27         int nViewId = SfxLokHelper::getView(); // currently active.
28     

** CID 1633780:  High impact quality  (GLOBAL_INIT_ORDER)


________________________________________________________________________________________________________
*** CID 1633780:  High impact quality  (GLOBAL_INIT_ORDER)
/sw/source/core/view/viewsh.cxx: 92 in ()
86     
87     #include <frameformats.hxx>
88     #include <fmtcntnt.hxx>
89     
90     bool SwViewShell::sbLstAct = false;
91     ShellResource *SwViewShell::spShellRes = nullptr;
>>>     CID 1633780:  High impact quality  (GLOBAL_INIT_ORDER)
>>>     The constructor of global object "SwViewShell::spCareDialog" itself makes use of global object "tools::gDeinitDeleteList" defined in another compilation unit.  The order of construction is unspecified, so "SwViewShell::spCareDialog" might be created before "tools::gDeinitDeleteList" is available.
92     tools::DeleteOnDeinit<std::shared_ptr<weld::Window>> SwViewShell::spCareDialog {};
93     
94     static bool bInSizeNotify = false;
95     
96     
97     using namespace ::com::sun::star;

** CID 1633779:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/xmloff/source/draw/ximpstyl.cxx: 1311 in SdXMLStylesContext::ImpSetGraphicStyles(const com::sun::star::uno::Reference<com::sun::star::container::XNameAccess> &, XmlStyleFamily, const rtl::OUString &) const()


________________________________________________________________________________________________________
*** CID 1633779:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/xmloff/source/draw/ximpstyl.cxx: 1311 in SdXMLStylesContext::ImpSetGraphicStyles(const com::sun::star::uno::Reference<com::sun::star::container::XNameAccess> &, XmlStyleFamily, const rtl::OUString &) const()
1305                         {
1306                             uno::Reference< style::XStyle > xNewStyle( xServiceFact->createInstance(), uno::UNO_QUERY);
1307     
1308                             if(xNewStyle.is())
1309                             {
1310                                 // remember style
>>>     CID 1633779:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>>     "xNewStyle" is copied in a call to copy assignment "operator =", when it could be moved instead.
1311                                 xStyle = xNewStyle;
1312     
1313                                 // add new style to graphics style pool
1314                                 uno::Reference< container::XNameContainer > xInsertContainer(xPageStyles, uno::UNO_QUERY);
1315                                 if(xInsertContainer.is())
1316                                     xInsertContainer->insertByName(aStyleName, uno::Any( xStyle ) );

** CID 1633778:  High impact quality  (GLOBAL_INIT_ORDER)


________________________________________________________________________________________________________
*** CID 1633778:  High impact quality  (GLOBAL_INIT_ORDER)
/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx: 10711 in ()
10705     OParseContext		    OSQLParser::s_aDefaultContext;
10706     
10707     sal_Int32			OSQLParser::s_nRefCount	= 0;
10708     //	::osl::Mutex		OSQLParser::s_aMutex;
10709     OSQLScanner*		OSQLParser::s_pScanner = nullptr;
10710     OSQLParseNodesGarbageCollector*		OSQLParser::s_pGarbageCollector = nullptr;
>>>     CID 1633778:  High impact quality  (GLOBAL_INIT_ORDER)
>>>     The constructor of global object "connectivity::OSQLParser::s_xLocaleData" itself makes use of global object "tools::gDeinitDeleteList" defined in another compilation unit.  The order of construction is unspecified, so "connectivity::OSQLParser::s_xLocaleData" might be created before "tools::gDeinitDeleteList" is available.
10711     tools::DeleteOnDeinit<css::uno::Reference< css::i18n::XLocaleData4>> OSQLParser::s_xLocaleData(tools::DeleteOnDeinitFlag::Empty);
10712     
10713     void setParser(OSQLParser* _pParser)
10714     {
10715     	xxx_pGLOBAL_SQLPARSER = _pParser;
10716     }

** CID 1633777:  High impact quality  (GLOBAL_INIT_ORDER)


________________________________________________________________________________________________________
*** CID 1633777:  High impact quality  (GLOBAL_INIT_ORDER)
/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx: 526 in ()
520         popListItem();
521         popStructureElement(vcl::PDFWriter::List);
522     }
523     
524     // init static break iterator
525     tools::DeleteOnDeinit<uno::Reference<css::i18n::XBreakIterator>>
>>>     CID 1633777:  High impact quality  (GLOBAL_INIT_ORDER)
>>>     The constructor of global object "drawinglayer::processor2d::VclMetafileProcessor2D::mxBreakIterator" itself makes use of global object "tools::gDeinitDeleteList" defined in another compilation unit.  The order of construction is unspecified, so "drawinglayer::processor2d::VclMetafileProcessor2D::mxBreakIterator" might be created before "tools::gDeinitDeleteList" is available.
526         VclMetafileProcessor2D::mxBreakIterator;
527     
528     VclMetafileProcessor2D::VclMetafileProcessor2D(const geometry::ViewInformation2D& rViewInformation,
529                                                    OutputDevice& rOutDev)
530         : VclProcessor2D(rViewInformation, rOutDev)
531         , mpMetaFile(rOutDev.GetConnectMetaFile())

** CID 1633776:  High impact quality  (GLOBAL_INIT_ORDER)


________________________________________________________________________________________________________
*** CID 1633776:  High impact quality  (GLOBAL_INIT_ORDER)
/sw/source/core/txtnode/fntcache.cxx: 75 in ()
69     SwFntObj *pLastFont = nullptr;
70     
71     constexpr Color gWaveCol(COL_GRAY);
72     
73     tools::Long SwFntObj::s_nPixWidth;
74     MapMode* SwFntObj::s_pPixMap = nullptr;
>>>     CID 1633776:  High impact quality  (GLOBAL_INIT_ORDER)
>>>     The constructor of global object "s_pFntObjPixOut" itself makes use of global object "tools::gDeinitDeleteList" defined in another compilation unit.  The order of construction is unspecified, so "s_pFntObjPixOut" might be created before "tools::gDeinitDeleteList" is available.
75     static tools::DeleteOnDeinit< VclPtr<OutputDevice> > s_pFntObjPixOut {};
76     
77     void SwFntCache::Flush( )
78     {
79         if ( pLastFont )
80         {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DF3wA_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtFALgPD8hT8ltP7kYsaq51DbyvIssnNzmVP4O6r3Hos5ozdUgJm2cISRnxT62zZ20yk4M9oE-2Bls-2FHByu5ig7obuwKYOWOLwuZasoyvUg6pIicivFXaYtqkeP62v06g47N70n1SfXjh-2FrMSmq9EHAk8gScgpEWE5yIdFXru-2BZqupY-3D




[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux