New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
9 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1633260:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/sdext/source/pdfimport/tree/pdfiprocessor.cxx: 573 in pdfi::PDFIProcessor::intersectClipToStroke(const com::sun::star::uno::Reference<com::sun::star::rendering::XPolyPolygon2D> &)()


________________________________________________________________________________________________________
*** CID 1633260:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/sdext/source/pdfimport/tree/pdfiprocessor.cxx: 573 in pdfi::PDFIProcessor::intersectClipToStroke(const com::sun::star::uno::Reference<com::sun::star::rendering::XPolyPolygon2D> &)()
567     
568         for (const basegfx::B2DPolygon & rExtractedHairline : aHairlines)
569         {
570             aTmpClip.append(rExtractedHairline);
571         }
572     
>>>     CID 1633260:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>>     "aTmpClip" is copied in a call to copy assignment "operator =", when it could be moved instead.
573         aNewClip = aTmpClip;
574     
575         if( aCurClip.count() )  // #i92985# adapted API from (..., false, false) to (..., true, false)
576             aNewClip = basegfx::utils::clipPolyPolygonOnPolyPolygon( aCurClip, aNewClip, true, false );
577     
578         getCurrentContext().Clip = aNewClip;

** CID 1633259:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/sdext/source/pdfimport/tree/pdfiprocessor.cxx: 578 in pdfi::PDFIProcessor::intersectClipToStroke(const com::sun::star::uno::Reference<com::sun::star::rendering::XPolyPolygon2D> &)()


________________________________________________________________________________________________________
*** CID 1633259:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/sdext/source/pdfimport/tree/pdfiprocessor.cxx: 578 in pdfi::PDFIProcessor::intersectClipToStroke(const com::sun::star::uno::Reference<com::sun::star::rendering::XPolyPolygon2D> &)()
572     
573         aNewClip = aTmpClip;
574     
575         if( aCurClip.count() )  // #i92985# adapted API from (..., false, false) to (..., true, false)
576             aNewClip = basegfx::utils::clipPolyPolygonOnPolyPolygon( aCurClip, aNewClip, true, false );
577     
>>>     CID 1633259:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>>     "aNewClip" is copied in a call to copy assignment "operator =", when it could be moved instead.
578         getCurrentContext().Clip = aNewClip;
579     }
580     
581     void PDFIProcessor::hyperLink( const geometry::RealRectangle2D& rBounds,
582                                    const OUString&           rURI )
583     {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3D2E1k_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGt1WiO92ww9fjUUE-2BLESjxJFsMbFUP1D1TkLs7OUDgs8XwgZyrkRTI4U7XUSWyHsRDD8VxCzkFcZLvO-2Ffrv9HByp4UkCPtmqKlKzu9BXiH4Cjfti3ckAY9qLdHzwKot95KAYrmIexY1UycRZOVifHpDEp07MIKCVdKsvstkph3p1c-3D